301985 - Fixing warnings

Status: RESOLVED DUPLICATE of bug 302152

(NSPR :: NSPR, defect)

Description

[Mikhail T.]

User-Agent:       Mozilla/5.0 (compatible; Konqueror/3.4; FreeBSD; X11; amd64) KHTML/3.4.1 (like Gecko)
Build Identifier: 

A number of trivial warnings prevent nspr-code from compiling cleanly with 
-Wall -Werror. This makes use of these compiler options difficult, when 
searching for real bugs. 

Reproducible: Always

Comment 1

[Mikhail T.]

Attachment: Fix the easiest warnings

Comment 2

[Mikhail T.]

Attachment: One more file patched (two hunks)

Comment 3

[Takanori MATSUURA]

Is this dup. of bug 302152?

Comment 4

[Mikhail T.]

(In reply to Takanori MATSUURA from comment #3)
> Is this dup. of bug 302152?

So it would seem, yes, but -- 10 years later -- I am not certain...

Comment 5

[Chris Peterson [:cpeterson]]

These NSPR patches from 2005 are no longer relevant. NSPR warnings should be fixed upstream.

Comment 6

[Mikhail T.]

(In reply to Chris Peterson [:cpeterson] from comment #5)
> These NSPR patches from 2005 are no longer relevant.

Unfortunately, NSPR still generates TONNES of compiler-warnings today, 10 years later... Here are the up-to-date patches as used by the FreeBSD port. The patches aren't FreeBSD-specific and ought to be merged into release:

https://svnweb.freebsd.org/ports/head/devel/nspr/files/patch-warnings?view=log
https://svnweb.freebsd.org/ports/head/devel/nspr/files/patch-tests?view=log
https://svnweb.freebsd.org/ports/head/devel/nspr/files/patch-libtests?view=log

> NSPR warnings should be fixed upstream.

What is "upstream" here? Is NSPR no longer a Mozilla product?

Comment 7

[Chris Peterson [:cpeterson]]

(In reply to Mikhail T. from comment #6)
> (In reply to Chris Peterson [:cpeterson] from comment #5)
> > NSPR warnings should be fixed upstream.
> 
> What is "upstream" here? Is NSPR no longer a Mozilla product?

Good question. By "upstream", I meant not in the mozilla-central Mercurial repo. NSPR and NSS are maintained in a CVS repo shared by some non-Mozilla projects, independent of Firefox code.