Open Bug 301988 Opened 14 years ago Updated 4 years ago

TONS of compiler warnings in pr/tests

Categories

(NSPR :: NSPR, defect)

4.8.7
Other
FreeBSD
defect
Not set

Tracking

(Not tracked)

People

(Reporter: mi+mozilla, Assigned: mi+mozilla, NeedInfo)

References

(Blocks 1 open bug)

Details

(Whiteboard: [build_warning])

Attachments

(1 file, 3 obsolete files)

User-Agent:       Mozilla/5.0 (compatible; Konqueror/3.4; FreeBSD; X11; amd64) KHTML/3.4.1 (like Gecko)
Build Identifier: 

There are so many -- on 64-bit systems especially -- I could not fix them all. 
But I fixed many... Please, look into the attached patch. Thanks! 

Reproducible: Always
Attachment #190370 - Attachment is obsolete: true
QA Contact: wtchang → nspr
Attached patch Updated for nspr-4.8.7 (obsolete) — Splinter Review
This is an updated version -- print_thread's second argument is now an int and thus should be printed as %d, not %ld.
Attachment #190676 - Attachment is obsolete: true
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: other → 4.8.7
Whiteboard: [build_warning]
Attachment #539705 - Flags: review?(ted.mielczarek)
Assignee: wtc → mi+mozilla
I don't have commit-privileges, so assigning my own patch to me seems wrong...
The assignee is typically set to the patch author, regardless of commit privs. To get this committed once you have r+, add "checkin-needed" to the keywords field :-)
Attachment #539705 - Flags: review?(wtc)
Since the bug's creation this patch was part of the FreeBSD port devel/nspr and, as such, was used by all Thunderbird and Firefox (and others) built and used on the OS.

This update is what's currently used by the FreeBSD port of 4.9.
Attachment #539705 - Attachment is obsolete: true
Attachment #604097 - Flags: review?(ted.mielczarek)
Attachment #539705 - Flags: review?(wtc)
Attachment #539705 - Flags: review?(ted.mielczarek)
Review stalled?
Comment on attachment 604097 [details] [diff] [review]
Updated for nspr-4.9

wtc, would you have time to have a look?
Attachment #604097 - Flags: review?(wtc)
So, nobody wants to review? Sigh...
Flags: needinfo?(wtc)
Flags: needinfo?(ted)
I'm sorry, I just really don't have the bandwidth for NSPR work that's not critical to some effort.
Flags: needinfo?(ted)
Flags: needinfo?(nelson)
When Mozilla's evangelists tell another story about how friendly and fast Firefox developers are, I always remembering about this bug... )
Wow... Where did the 10 years go? I'm old...
(In reply to Mikhail T. from comment #12)
> Wow... Where did the 10 years go? I'm old...
Где мои 15 лет...© ;)
You need to log in before you can comment on or make changes to this bug.