302047 - Firefox password manager uses nsIForm

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect)

Description

[Boris Zbarsky [:bzbarsky]]

I'd really like to deCOMify nsIForm a bit, and I'm not sure why the Firefox
password manager is using it...  It looks like it wants ResolveName, but
wouldn't calling GetNamedItem on form.elements give the same result, with only
frozen APIs being used?  Similarly, the indexing stuff could work with frozen
APIs through form.elements...

Comment 1

[Boris Zbarsky [:bzbarsky]]

Given how much people copy our code in their extensions, I'd really like to see
this fixed...  Firefox-specific code just should not be using unfrozen
semi-private layout interfaces when there are frozen DOM equivalents.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

I started looking into doing this, but I couldn't find a good DOM way to retrieve the index of an element in an HTMLCollection, or to get it's neighboring nodes. The current method of searching forwards and then backwards from a given element requires that.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Hmm..  I guess just manually doing IndexOf() (via linear search) here would be a little slow due to all the addrefs, eh?

jst, would it make sense to have an nsIDOMNSHTMLCollection or something that exposes an indexOf()-like method?

Comment 4

[Mike Connor [:mconnor]]

bz, this is about deCOM, which would be trunk only, I'd imagine.  Any reason to fix this on branch or can this drop off the Fx2 list?

Comment 5

[Mike Connor [:mconnor]]

clearing this off the list for now.  Boris, if this is important on the 1.8.1 path, please mark it blocking again.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Yeah, this is not relevant to FF 2.

I'd still like to see this fixed on trunk, though...  I won't have a chance to do it, but it'd be nice if someone did...

Comment 7

[Justin Dolske [:Dolske]]

This was fixed as a side effect of moving password manger to JS, in bug 374723.

Comment 8

[Mike Connor [:mconnor]]

sweet sweet byproducts