302120 - Broken Keyboard Navigation with new folder location picker widget

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Scott MacGregor]

Here's a bug for the issue we were talking about Neil.

Bring up the search dialog, focus the account / folders to search picker.

Without opening up the menupoup, use the keyboard to navigate through the
options. Note the failure to due so and the JS error.

Neil had some ideas on how to add this functinality.

Comment 1

[[e-mail]]

Attachment: Fix JS exception

This was copied from line 1700 but that was too far away to include in the
diff.

Comment 2

[[e-mail]]

Comment on attachment 190546 [details] [diff] [review]
Fix JS exception

Trivial patch to prevent inappropriate JS exceptions.

Comment 3

[[e-mail]]

Attachment: -w version of following patch

The -w version is useful because it has a different idea as to which code
moved.

Comment 4

[[e-mail]]

Attachment: Support up/down/home/end

I suddenly realised that page up/down only work when the popup is open,
so in fact the previous attachment isn't an exact -w diff, but it'll do.

Comment 5

[Scott MacGregor]

Comment on attachment 192440 [details] [diff] [review]
Support up/down/home/end

thanks Neil

Comment 6

[[e-mail]]

Attachment 192440 [details] [diff] checked in.
Do you want me to look into navigating by typing the folder name?

Comment 7

[Stefan Magdalinski]

as a keyboard only user, being able to navigate the folder tree with FAYT style
keys (or even just first letters) would be an awesome accessibility win.

I think I filed an RFE on this once, but maybe I didn't

Comment 8

[David :Bienvenu]

navigating by typing the folder name would be great, and would help with
usability of the new widget when you have a ton of folders, as I do.

Comment 9

[Asa Dotzler [:asa]]

did this land on the 1.8 branch for b4? if so, could you add the fixed1.8
keyword? thanks.

Comment 10

[[e-mail]]

Resolving as fixed for up/down, I'll spin up a new bug about FAYT style.

Comment 11

[Mike Cowperthwaite]

(In reply to comment #10)
> Resolving as fixed for up/down, I'll spin up a new bug about FAYT style.

Neil, did you do this?  xref bug 315367

Comment 12

[[e-mail]]

(In reply to comment #11)
>(In reply to comment #10)
>>Resolving as fixed for up/down, I'll spin up a new bug about FAYT style.
>Neil, did you do this?
Oops, I forgot :-( Just submitted bug 322622.