Broken Keyboard Navigation with new folder location picker widget

RESOLVED FIXED

Status

MailNews Core
Backend
RESOLVED FIXED
12 years ago
9 years ago

People

(Reporter: Scott MacGregor, Assigned: neil@parkwaycc.co.uk)

Tracking

({fixed1.8})

Trunk
x86
Windows XP
fixed1.8

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

12 years ago
Here's a bug for the issue we were talking about Neil.

Bring up the search dialog, focus the account / folders to search picker.

Without opening up the menupoup, use the keyboard to navigate through the
options. Note the failure to due so and the JS error.

Neil had some ideas on how to add this functinality.
(Assignee)

Comment 1

12 years ago
Created attachment 190546 [details] [diff] [review]
Fix JS exception

This was copied from line 1700 but that was too far away to include in the
diff.
Attachment #190546 - Flags: superreview?(roc)
Attachment #190546 - Flags: review?(bzbarsky)
Attachment #190546 - Flags: review?(bzbarsky) → review+
Attachment #190546 - Flags: superreview?(roc) → superreview+
(Assignee)

Comment 2

12 years ago
Comment on attachment 190546 [details] [diff] [review]
Fix JS exception

Trivial patch to prevent inappropriate JS exceptions.
Attachment #190546 - Flags: approval1.8b4?

Updated

12 years ago
Attachment #190546 - Flags: approval1.8b4? → approval1.8b4+
(Assignee)

Comment 3

12 years ago
Created attachment 192439 [details] [diff] [review]
-w version of following patch

The -w version is useful because it has a different idea as to which code
moved.
(Assignee)

Comment 4

12 years ago
Created attachment 192440 [details] [diff] [review]
Support up/down/home/end

I suddenly realised that page up/down only work when the popup is open,
so in fact the previous attachment isn't an exact -w diff, but it'll do.
Attachment #192439 - Attachment is obsolete: true
Attachment #192440 - Flags: superreview?(mscott)
(Reporter)

Comment 5

12 years ago
Comment on attachment 192440 [details] [diff] [review]
Support up/down/home/end

thanks Neil
Attachment #192440 - Flags: superreview?(mscott) → superreview+
(Assignee)

Updated

12 years ago
Attachment #192440 - Flags: approval1.8b4?

Updated

12 years ago
Attachment #192440 - Flags: approval1.8b4? → approval1.8b4+
(Assignee)

Comment 6

12 years ago
Attachment 192440 [details] [diff] checked in.
Do you want me to look into navigating by typing the folder name?

Comment 7

12 years ago
as a keyboard only user, being able to navigate the folder tree with FAYT style
keys (or even just first letters) would be an awesome accessibility win.

I think I filed an RFE on this once, but maybe I didn't

Comment 8

12 years ago
navigating by typing the folder name would be great, and would help with
usability of the new widget when you have a ton of folders, as I do.

Comment 9

12 years ago
did this land on the 1.8 branch for b4? if so, could you add the fixed1.8
keyword? thanks.
(Assignee)

Comment 10

12 years ago
Resolving as fixed for up/down, I'll spin up a new bug about FAYT style.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8
Resolution: --- → FIXED

Comment 11

12 years ago
(In reply to comment #10)
> Resolving as fixed for up/down, I'll spin up a new bug about FAYT style.

Neil, did you do this?  xref bug 315367
(Assignee)

Comment 12

12 years ago
(In reply to comment #11)
>(In reply to comment #10)
>>Resolving as fixed for up/down, I'll spin up a new bug about FAYT style.
>Neil, did you do this?
Oops, I forgot :-( Just submitted bug 322622.
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.