302200 - uninitialized value when saving email prefs

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Rob Siklos [:robzilla]]

When you save your e-mail prefs and you don't have all of the items in the
"Global options" section checked, you get uninitialized value messages.

Comment 1

[Rob Siklos [:robzilla]]

Attachment: robzilla_v1

Comment 2

[Frédéric Buclin]

Comment on attachment 190553 [details] [diff] [review]
robzilla_v1

>     foreach my $event (GLOBAL_EVENTS) {
>-        if (1 == $cgi->param("email-" . REL_ANY . "-$event")) {
>+        if (defined($cgi->param("email-" . REL_ANY . "-$event")) &&
>+            1 == $cgi->param("email-" . REL_ANY . "-$event")) {
>             $dbh->do("INSERT INTO email_setting " . 
>                      "(user_id, relationship, event) " . 
>                      "VALUES ($userid, " . REL_ANY . ", $event)");

This patch works *but*:

1) if ($cgi->param("email-" . REL_ANY . "-$event")) would suffice. But as this
is done this way in the rest of the file, I won't deny review due to that.

2) This should be written:

if (defined($cgi->())
    && $cgi->() == 1) 
{

Please update this patch taking into account my comment 2).

Comment 3

[Rob Siklos [:robzilla]]

Attachment: robzilla_v2

ok, nit #2 fixed.

Comment 4

[Frédéric Buclin]

Comment on attachment 190560 [details] [diff] [review]
robzilla_v2

>+        if (defined($cgi->param("email-" . REL_ANY . "-$event"))
>+            && $cgi->param("email-" . REL_ANY . "-$event") == 1) {

Reread my previous comment and note the position of the bracket '{'.

If the test can be written on one line:

if ($foo eq $bar) {
    ....
}

If the test requires several lines:

if ($foo eq $bar
    && $id1 != $id2)
{
    ...
}

Comment 5

[Rob Siklos [:robzilla]]

Attachment: robzilla_v3

Comment 6

[Frédéric Buclin]

Comment on attachment 190562 [details] [diff] [review]
robzilla_v3

r=LpSolit

Comment 7

[Frédéric Buclin]

tip:

Checking in userprefs.cgi;
/cvsroot/mozilla/webtools/bugzilla/userprefs.cgi,v  <--  userprefs.cgi
new revision: 1.79; previous revision: 1.78
done


2.20rc1:

Checking in userprefs.cgi;
/cvsroot/mozilla/webtools/bugzilla/userprefs.cgi,v  <--  userprefs.cgi
new revision: 1.75.4.3; previous revision: 1.75.4.2
done