302259 - Weird-looking accesskey underline in Options -> Privacy -> HIstory

Status: RESOLVED WORKSFORME

(Firefox :: Settings UI, defect)

Description

[Wayne blacklock]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.7.10) Gecko/20050717 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.7.10) Gecko/20050717 Firefox/1.0.6

Under the history tab is says:

"Remember_ visited pages for the last"

Presumably it is meant to no have the "_".



Reproducible: Always

Steps to Reproduce:
1. Go to Tools
2. Options
3. Privacy
4. History
Actual Results:  
"Remember_ visited pages for the last"

Expected Results:  
"Remember visited pages for the last"

Comment 1

[Adam Guthrie]

According to LXR, we don't.
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/locales/en-US/chrome/browser/pref/pref-privacy.dtd&mark=6

This is possibly being caused by an extension. Do you see this in safe-mode?
http://kb.mozillazine.org/Safe_mode

Comment 2

[Daniel Veditz [:dveditz]]

In spite of the linked source, it *is* there -- thanks, confirming.

Comment 3

[Daniel Veditz [:dveditz]]

You know what, it's not r_, it's r underlined but it's really hard to read. This
is the accesskey (pageHis.accesskey in the source Adam linked to).

But why does just this one option on that dialog have an access key? It's ugly
and confusing, but not actually a bug.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Well, ugly is one thing, but I'm not sure it's a valid argument to get rid of
accesskeys :). In any case, the dialog is drastically different on the trunk,
and is much less jarring given that all options have accesskeys, so this no
longer applies.

Comment 5

[Neil Turner]

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b3)
Gecko/20050712 Firefox/1.0+

Works for me in Deer Park Alpha 2: the 'R' of remember is underlined correctly.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Closing as WFM, prefs rewrite took care of this.