30232 - Remove char*s from mozTXTToHTMLConv

Status: VERIFIED WONTFIX

(MailNews Core :: MIME, defect, P3)

Description

[Ben Bucksch (:BenB)]

For bug #21203 / bug #26915, mscott replaced nsStrings with |PRUnichar*|s.
See bug #21203 for an explanation, why I don't think. this is a good idea.

Chris Waterson wrote, that I can go back to nsString, if that is no perf
decrease in comparison to the current state. I think, this is possible.

I even argue, that this is already true, because mscott's changes decreased
performance for western human language by factor 2, and I think, this is the
vastly most important case (much more important than source code, where my
version was weak). However, I will see, if I can increase performance for the
other cases (source code etc.) as well.

Comment 1

[Ben Bucksch (:BenB)]

No milestone goal for now, but propably M15.

> See bug #21203 for an explanation, why I don't think. this is a good idea.

Summary: Stability, Unmaintainable for me

Comment 2

[Ben Bucksch (:BenB)]

I thought about it: The recent checkin was too much.

I really see no reason for checking in mscott's patch: It decreases stability,
performance and maintainability. But I'm willing to revisit this, if somebody
shows me a rational explanation.

Currently, I don't have a desire to fix this bug (in order to make maintaining
the class possible again for me). WONTFIX.

Comment 3

[Ben Bucksch (:BenB)]

With the new string implementations, we propably don't need char*s. If I
understood it right, there'll be an implementation, which can handle usage of
|Right()| very well.

Use the last (already optimized) mozTXTToHTMLConv implementation using nsStrings
(can be found at bug 26915), convert it to the new string API, optimize it with
the new string implementations and redo all recent changes to the current tree
version of mozTXTToHTMLConv.

Comment 4

[Håkan Waara]

Any more comments on this, or can we verify this as a WONTFIX?

Comment 5

[Ben Bucksch (:BenB)]

> we verify this as a WONTFIX?

Please leave that to somebody from the Mailnews team.

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

verified