302466 - Context menu of an Extension in EM should say "Find Update" instead of "Find Updates"

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Stebs]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050727 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050727 Firefox/1.0+

After the latest checkins for EM and Extension Update, the "Find Updates" Button
in EM updates all Extensions while the Context Menu item "Find Updates" of an
Extension updates only that single Extension.
This Context menu item should be labeled "Find Update" to reflect this difference. 


Reproducible: Always

Steps to Reproduce:

Comment 1

[Dave Townsend [:mossop] (PTO until Aug 21st)]

Confirming, this is nice and confusing for the user.

Comment 2

[Jaime Mitchell (use [e-mail] for email)]

Attachment: Add additional entities

The problem is that the context menu and the menu button share the same
entities. This patch adds an additional entity for the context menu with the
"Find Update" string and an access key of "F"

Comment 3

[Jaime Mitchell (use [e-mail] for email)]

Comment on attachment 190876 [details] [diff] [review]
Add additional entities

Robert, mconnor suggested you might be able to review this, thanks.

Comment 4

[Robert Strong (they/them - no direct email)]

Comment on attachment 190876 [details] [diff] [review]
Add additional entities

this is fine but I would prefer it if either the context menu entity used
updateAddon (Ben has been using the term addon) or updateItem instead of
updateExtension since it applies to both themes and extensions.

Either way r=me

Comment 5

[Jaime Mitchell (use [e-mail] for email)]

Attachment: Change to updateAddon

Change updateExtension to updateAddon, thanks Robert. Carrying forward review+

Comment 6

[Jaime Mitchell (use [e-mail] for email)]

Comment on attachment 190947 [details] [diff] [review]
Change to updateAddon

Requesting aproval for a simple fix that changes a slightly confusing part of
the EM UI

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Checking in locales/en-US/chrome/mozapps/extensions/extensions.dtd;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/extensions/extensions.dtd,v
 <--  extensions.dtd
new revision: 1.8; previous revision: 1.7
done
Checking in mozapps/extensions/content/extensions.xul;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.xul,v  <-- 
extensions.xul
new revision: 1.37; previous revision: 1.36
done