302644 - relogin.cgi may ask you to login... before logging you out

Status: RESOLVED FIXED

(Bugzilla :: User Accounts, defect)

Description

[Frédéric Buclin]

Due to bug 279716, if you change your password while requirelogin is on, logging
out will ask you to log in first !?!? This is very confusing!

Fixing bug 279716 would fix this testcase, but relogin.cgi should never ask you
to log in... as the next action will be to log out the user.

The simple fix is to replace Bugzilla->login() by Bugzilla->login(LOGIN_OPTIONAL).

Comment 1

[Frédéric Buclin]

Attachment: patch for 2.20, v1

Comment 2

[Marc Schumann [:Wurblzap]]

Comment on attachment 190959 [details] [diff] [review]
patch for 2.20, v1

r=wurblzap for 2.20, and on an unrotted patch for trunk.

Bugzilla->logout() clears cookies for userid 0 if not logged in, so we're safe
here.

Comment 3

[Frédéric Buclin]

Attachment: patch for the tip, v1

Comment 4

[Frédéric Buclin]

tip:

Checking in relogin.cgi;
/cvsroot/mozilla/webtools/bugzilla/relogin.cgi,v  <--  relogin.cgi
new revision: 1.27; previous revision: 1.26
done

2.20rc2:

Checking in relogin.cgi;
/cvsroot/mozilla/webtools/bugzilla/relogin.cgi,v  <--  relogin.cgi
new revision: 1.25.10.1; previous revision: 1.25
done