302821 - firefox crashes when working with multiple tabs, usually when closing a tab.

Status: RESOLVED FIXED

(Core Graveyard :: Widget: BeOS, defect)

Description

[Doug Shelton]

User-Agent:       Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8b4) Gecko/20050727 Firefox/1.0+
Build Identifier: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8b4) Gecko/20050727 Firefox/1.0+

Recent builds of Deer Park from CVS crash intermittantly when working with
multiple open tabs, usually when closing a tab.

Reproducible: Sometimes

Steps to Reproduce:
1. open multiple tabs
2. toggle between them
3. close the current tab using the "tab close" button.

Actual Results:  
Firefox crashes (sometimes).

Expected Results:  
display the previous tab.

crashes with a Debugger call.  Stack crawl attached.  Regardless of situation
leading to the crash, seems like the stack crawl always has the same 5 entries
at the top.

Comment 1

[Doug Shelton]

Attachment: debug stack crawl after crash

Comment 2

[Boris Zbarsky [:bzbarsky]]

Sounds like a BeOS widgetry bug...

Comment 3

[tqh]

Yes, it is.

Comment 4

[Disreali]

I've had this happen to me when trying to log into 2 different sites on 2 tabs.
Using Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.7.7) Gecko/20050426 Firefox/1.0.3
on Zeta. 
Reference http://bugzilla.yellowtab.com/show_bug.cgi?id=1016

Would this be the same issue or does it deserve it's own bug report?

Comment 5

[Doug Shelton]

Attachment: fixes mismatched lock/unlock pair

r?
a simple two-line fix to move a misplaced unlock.  please review.

Comment 6

[tqh]

Comment on attachment 192381 [details] [diff] [review]
fixes mismatched lock/unlock pair

r=[e-mail]

Comment 7

[Doug Shelton]

The bug Disreali mentions in comment #4 appears to be related to firefox bug
277015 which reports a hang upon login to some (not all) secure sites.

Comment 8

[tqh]

Comment on attachment 192381 [details] [diff] [review]
fixes mismatched lock/unlock pair

I guess this one should be checked in both 1.8 and trunk.

Comment 9

[tqh]

Can someone commit this change?

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

Maybe there should be an nsAutoLocker class that locks the looper in its
constructor and unlocks it in its destructor...

trunk:
Checking in widget/src/beos/nsWindow.cpp;
/cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.92; previous revision: 1.91
done

MOZILLA_1_8_BRANCH:
Checking in widget/src/beos/nsWindow.cpp;
/cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.91.4.1; previous revision: 1.91
done