302866 - Implement Edit->Cut for bookmarks

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: Bookmarks, defect)

Description

[Simon Fraser [no longer active]]

We need to support Cut (as in Cut/Copy/Paste) for bookmark items.

Comment 1

[froodian (Ian Leue)]

-> Me

Comment 2

[Simon Fraser [no longer active]]

Hint: you'll need to serialize bookmarks into a propertly list format and put that on the clipboard, rather than just putting bookmark IDs on the clipboard like we do now.

Comment 3

[Chris Lawson (gone)]

Pretty sure Ian isn't working on this anymore :(

I might be able to take a look by the end of the year, though.

Comment 4

[Chris Lawson (gone)]

Taking to keep it on my radar.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to Simon Fraser from comment #2)
> Hint: you'll need to serialize bookmarks into a property list format and
> put that on the clipboard, rather than just putting bookmark IDs on the
> clipboard like we do now.

We also need to do this to support this workflow (which really is a pseudo-cut):

1) Copy some bookmark(s)
2) Delete the original(s)
3) Paste

We currently act like we paste, but paste nothing (obviously) and log "Failed to find bm item with uuid XXXXX".

I thought we might be able to fall back to another format (WebURLsWithTitlesPboardType), but you lose shortcut, description, last visit, visit count, and whatever other metadata we keep, so we do need our own serialization format.

Chris, if you're not working on this any time soon, do you think it's [good first bug] material?  It seems like it might be, but I haven't looked into the code.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

[5:18pm] cl: i have no idea anymore :P
[5:19pm] cl: but my gut says if it had ever been GFB material, Simon would have fixed it in the first place

Chris isn't still looking into this, either.

Comment 7

[Chris Lawson (gone)]

(In reply to Simon Fraser from comment #2)
> Hint: you'll need to serialize bookmarks into a propertly list format and
> put that on the clipboard, rather than just putting bookmark IDs on the
> clipboard like we do now.

Doing this shouldn't be too terribly difficult, and is basically the same thing that Safari does. I'm not sure why Simon never got around to doing it in the first place, but having thought about it a bit more, I'd say it's reasonable GFB material.

Comment 8

[Chris Lawson (gone)]

Turns out the hard part isn't putting the plist *on* the pasteboard; it's reading it back out in a way that makes sense. At least, that's where I've run into a wall here.

Comment 9

[Bhaktavatsalam Nallanthighal]

Hello. I am interested in working on this. Can anyone give me some pointers on where to start?