302889 - GMail popup "mail sent" window doesn't close itself

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

When you compose a message in a new window in GMail, after you press send it
normally replaces itself with a message "This email has been sent" (or something
like that) and then closes itself after a couple of seconds. In today's trunk
build (post split-window) the close doesn't happen, it just stays open until the
user closes it.

Comment 1

[Martijn Wargers (dead)]

Works in 20050730 build. Probably also a fallout from bug 296639.

Comment 2

[Johnny Stenback (:jst)]

Attachment: Always set the outer window as event target.

This goes pretty deep, but on the surface the problem is that we're dispatching
events with an inner window as the event target when it should be the outer
window.

The reason the window didn't close was that our browser code didn't think the
window that was being closed was the one in the only remaining tab, and that
was because contentWindow == event.target check failed. The reason that failed
was that this was chrome code, so we got automatic wrapping of the event target
with XPCNativeWrapper. XPCNativeWrapper has an equality hook that compares the
native pointers, which in this case would be different.

Now, I also added an equality hook to the window objects with the split window
work, but since XPCNativeWrapper is wrapping one of the window objects here, we
don't end up in the window equality hook. Now having thought about his more
(even before I investigated this bug), I've realized that we probably don't
even need an equality hook on our window objects since we should never be
comparing an inner window against an outer in the first place... I'll file a
followup bug on that...

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 191287 [details] [diff] [review]
Always set the outer window as event target.

This changes which nsISupports* is passed to DispatchNewEvent, but that looks
ok, so r+sr=dbaron.

Comment 4

[Chase Phillips]

Comment on attachment 191287 [details] [diff] [review]
Always set the outer window as event target.

Frickin' sweet.

Comment 5

[Johnny Stenback (:jst)]

Fix checked in.

Comment 6

[Johnny Stenback (:jst)]

Fixed on the trunk before we branched for 1.8.