302891 - created event appears in list but doesn't show up on calendar views

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

I created an event, and it appears in the event list, but it doesn't appear in
any calendar view.  The event has a title, a location, and runs from 9am to 5pm
on Saturday, September 3.

When I initially input it, I entered a ending time before the starting time (5am
instead of 5pm), but I went back and corrected that before hitting "OK".

Other than that, there was nothing unusual about the process.  This is with
trunk Sunbird from yesterday (July 30).

Comment 1

[Joey Minta]

This is bizarre. I created an event with the same time-limits and it showed up
fine in both 7-30 and 7-31 nightlies for linux.  Are other events you created
(in the same calendar, or other calendars) displaying?  Are there any other
events taking place in that timeframe?  

Next, can you try with a nightly build from a day or two back, in case this has
something to do with all the tinderbox-orange over the weekend?

If all else fails, and there's nothing sensitive in the calendar, can you export
it and attach it to the bug?

Comment 2

[Myk Melez [:myk] [@mykmelez]]

> This is bizarre. I created an event with the same time-limits and it showed up
> fine in both 7-30 and 7-31 nightlies for linux.  Are other events you created
> (in the same calendar, or other calendars) displaying?  Are there any other
> events taking place in that timeframe?

All my other events are scheduled for this week (July 31-August 5).  I'm just
getting started with Sunbird, so I haven't entered any events besides this
week's and the one next month.


> Next, can you try with a nightly build from a day or two back, in case this 
> has something to do with all the tinderbox-orange over the weekend?

I tried with July 24's build, and it had the same result.


> If all else fails, and there's nothing sensitive in the calendar, can you 
> export it and attach it to the bug?

I'd rather email it to you directly if that's OK.  However, I've just done some
more experimenting, because when I started Sunbird today the event showed up,
and it turns out that if I change the date on my computer back to July 31, then
the event disappears again (on both the 7-30 and the 7-24 nightlies).

So the problem seems to be specific to the current date.  Perhaps, before I send
you my calendar, you can test setting your computer back a day and see if that
reproduces the problem.

Comment 3

[Joey Minta]

Confirmed when setting the computer's date to July 31 (and May 31, probably any
31).  In this case, no events show up for any month that doesn't also have 31
days.  Additionally, the minimonth refuses to refresh it's month label in
February when this happens.

Blocks 0.3a1

Comment 4

[Joey Minta]

Attachment: set date before month

sigh...I can't wait for the new views.

The problem was that when adjusting the start/end date for timezone problems,
the month was set before the date.  In these cases, this caused the month to
roll-over to the next month, and therefore the event never appeared on the
correct screen. (It didn't show in the next month either since then the query
start/end dates exclude it.)

I suspect the minimonth problem I mentioned is something similar, but that
should be handled separately, in my opinion.

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in.

Comment 6

[gekacheka]

Setting date before month is not a good idea.  It only works if current month
has 31 days.  Otherwise date can roll over.  For example, type the following
into js console:

var d = new Date(2005,01,14); d.setDate(31); d.setMonth(6); d


Suppose current date is in a month with less than 31 days.  Suppose it is
february 14.  By setting date then month, you may expect this to become july 31st.  

But since original date month has less than 31 days, setting the date to 31
rolls over, in this case to march 3, then setting the month to 6 makes it july 3
(months are 0-based, so 0 is january).

Instead, create a new date with all three at once, as new Date(2005,06,31). 
Setting the fields individually can cause rollovers in either order.

Comment 7

[Joey Minta]

Attachment: fix regression

Thanks for pointing this out.  This patch incorporates your suggestion, setting
the date all at once.  It's based off the current cvs code, including the
checkin of attachment 191274 [details] [diff] [review].

Comment 8

[gekacheka]

Comment on attachment 191763 [details] [diff] [review]
fix regression

r=gekacheka

Comment 9

[Joey Minta]

patch checked in

Comment 10

[Myk Melez [:myk] [@mykmelez]]

Created events show up on calendar views now.

Comment 11

[gekacheka]

>     //HACK because startDate is convert to the proper TZ, but
>     //startDate.jsDate is not

adding dep: Hack was buggy, would not be needed at all if bug 296659 can be fixed.