Closed
Bug 303130
Opened 20 years ago
Closed 20 years ago
Memory leak of mp_int in ECPoints_mul
Categories
(NSS :: Libraries, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
3.11
People
(Reporter: wtc, Assigned: wtc)
Details
Attachments
(1 file)
|
1.86 KB,
patch
|
douglas
:
review+
nelson
:
superreview+
|
Details | Diff | Splinter Review |
In mozilla/security/nss/lib/freebl/ecl/ecl_mult.c,
function ECPoints_mul, if k1p and k2p point to the
local mp_int variables k1t and k2t, we never call
mp_clear to free the memory associated with k1t and
k2t.
Also, when we go to the CLEANUP label on an error,
the local variables k1p and k2p may not have been
initialized, so they may be used uninitialized.
I will submit a patch that fixes both problems.
|
Assignee | |
Comment 1•20 years ago
|
||
Attachment #191383 -
Flags: superreview?(nelson)
Attachment #191383 -
Flags: review?(vipul.gupta)
|
|
Assignee | |
Updated•20 years ago
|
Attachment #191383 -
Flags: review?(vipul.gupta) → review?(mozilla.org)
|
||
Updated•20 years ago
|
Attachment #191383 -
Flags: review?(mozilla.org) → review+
|
|
Assignee | |
Comment 2•20 years ago
|
||
Thanks for the code review, Douglas. I checked in the
patch on the NSS trunk for NSS 3.11.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.11
|
||
Updated•20 years ago
|
Attachment #191383 -
Flags: superreview?(nelson) → superreview+
You need to log in
before you can comment on or make changes to this bug.
Description
•