303287 - [GREETING] Option to disable the 'C++ is evil' type messages in certain channels

Status: RESOLVED FIXED

(Webtools Graveyard :: Mozbot, defect, P5)

Description

[Colin Ogilvie [:cso]]

Provide an option to disable Mozbot responding to c++ is evil type messages in
channels...

Comment 1

[Colin Ogilvie [:cso]]

Attachment: Patch v1

This would make Timely (and other #developers) very happy I think :)

Comment 2

[Max Kanat-Alexander]

Comment on attachment 191509 [details] [diff] [review]
Patch v1

I'd rather just have an option to globally disable evil. It's not like it's
extremely useful, it's just cute. :-)

Comment 3

[Colin Ogilvie [:cso]]

Cute or not, there may be people that want it in certain channels - therefor I
think a per-channel config is the best way to go.

Comment 4

[Wolf [:wolf]]

See Bug 294822.

Comment 5

[Wolf [:wolf]]

Attachment: Per-Channel, w/ Global Disable Wildcard Option

So, I was originally going to wontfix this, in favor of a global way to disable all evil (a-la the patch in bug 294822.) thinking that mozbot already had enough mute X in Y style commands, but looking at the patch, I decided it was simple enough, with one modification, which was supporting a way to use the same pref to globally disable it.
Now, adding a channel of * will globally disable (i.e. match all channels) evil, or just specifying specific channel names (#developers, for example) will disable it for a single channel only.
Marking r+ to overrule the previous r- on the general method of the patch.

Comment 7

[Wolf [:wolf]]

Checking in BotModules/Greeting.bm;
/cvsroot/mozilla/webtools/mozbot/BotModules/Greeting.bm,v  <--  Greeting.bm
new revision: 2.23; previous revision: 2.22
done