303482 - Checksetup can't find MIME::Tools with Perl 5.8.0

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect, P1)

Description

[Joel Peshkin]

MIME::Tools cannot be found by the checksetup version checks on installations
with Perl 5.8.0

If the reference to MIME::Tools is changed to MIME::Parser, the exact correct
version number is correctly returned.

Comment 1

[Dave Miller [:justdave]]

maybe we need to additionally check for $ModuleName::version like CPAN does...

Comment 2

[Joel Peshkin]

I tried that.  It still doesn't help.
The problem is that $@ gets set if you require MIME::Tools instead of MIME::Parser

Comment 3

[Joel Peshkin]

Attachment: Change Tools to Parser

Comment 4

[Marc Schumann [:Wurblzap]]

Comment on attachment 191693 [details] [diff] [review]
Change Tools to Parser

This doesn't work for me (ActiveState perl on Windows). I'm told I should run
"ppm install MIME::Parser", which yields "Searching for 'MIME::Parser' returned
no results. Try a broader search first."

I've got MIME-tools 5.411a installed (which works with bug 126266 landed if I
trick Bugzilla into thinking 5.411 is sufficient). This package contains
MIME::Parser 5.406.

Comment 5

[Joel Peshkin]

Does this mean we just need to additionally change the hash from....


    'MIME::Tools'       => 'MIME-Tools',

to

    'MIME::Parser'       => 'MIME-Tools',

Comment 6

[Joel Peshkin]

Attachment: Revised to have ppm suggest correct name as well

This should do the trick, but I cannot test it on ASPN.

Comment 7

[Marc Schumann [:Wurblzap]]

Well, that looks better, checksetup.pl wants me to update MIME-tools to 5.417
now. When I |ppm install MIME-Tools|, I get told "Note: Package 'MIME-tools' is
already installed." A newer version of MIME-tools than 5.411a seems not to be
available via ppm at the moment...

I'm not so sure that MIME::Parser is the right source for the version number...
For my MIME-tools version 5.411a, MIME::Parser has version 5.406.

Comment 8

[Joel Peshkin]

Glob: Is MIME::Parser 5.406 recent enough???

Comment 9

[:glob ✱]

(In reply to comment #8)
> Glob: Is MIME::Parser 5.406 recent enough???

this patch was developed on MIME::Parser 5.406 (which is in MIME::Tools 5.417
and 5.411).

Comment 10

[Frédéric Buclin]

(In reply to comment #9)
> this patch was developed on MIME::Parser 5.406 (which is in MIME::Tools 5.417
> and 5.411).

Some users on IRC complained they couldn't find MIME::Tools 5.417 on Windows. I
told them to hack checksetup.pl to require MIME::Tools 5.411.

glob, if MIME::Parser 5.406 is in MIME::Tools 5.411, why requiring 5.417?
Couldn't we downgrade the minimum requirement to 5.411? Per Marc's comment 4 and
comment 7, there is no problem doing so.

Comment 11

[:glob ✱]

> Couldn't we downgrade the minimum requirement to 5.411? Per Marc's comment 4 and
> comment 7, there is no problem doing so.

i have no issues with this.

Comment 12

[Joel Peshkin]

Comment on attachment 191701 [details] [diff] [review]
Revised to have ppm suggest correct name as well

OK then... we'll check MIME::Parser for minimum version 5.406 and instruct PPM
users to install MIME-Tools while instructing CPAN users to install
MIME::Parser which, according to
http://search.cpan.org/~dskoll/MIME-tools-5.417/lib/MIME/Parser.pm will install
MIME::Tools

Comment 13

[Joel Peshkin]

Attachment: updated version numbers

Also fixed the mapping from MIME::Base64 to suggest the MIME-Base64 name for
the ASPN module.

Comment 14

[:glob ✱]

Comment on attachment 191886 [details] [diff] [review]
updated version numbers

r=glob

Comment 15

[Marc Schumann [:Wurblzap]]

Comment on attachment 191886 [details] [diff] [review]
updated version numbers

r=wurblzap.

Comment 16

[Joel Peshkin]

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.424; previous revision: 1.423
done