303570 - js Error on Sunbird shutdown (remove gICalLib, gEventSource?)

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Joey Minta]

When shutting down Sunbird, debug builds will show that there is a js error in
calendarFinish(): "gEventSource has no properties". 

This is a relic from the old back-end.  The line currently serves no purpose. 
The only reason it hasn't caused more problems is that it's the last line of the
function.  It can easily be removed, but ideally, I'd like to use this bug to
just remove all references to gICalLib and gEventSource.
http://lxr.mozilla.org/mozilla/search?string=gICalLib
http://lxr.mozilla.org/mozilla/search?string=gEventSource

The js error blocks 0.3a1, not sure if the general removal does.

Comment 1

[Joey Minta]

Attachment: remove gICalLib and gEventSource

This patch removes the majority of references to gEventSource and gICalLib. 
See comment #0 for the lxr string searches.

References not removed:
-any references in files no longer included (ie. alertDialog.js,
calendarManager.js)
-commented out references in view code only
-calendar.js line 974.	This is removed in the 'Select All' patch on bug
275695.

Comment 2

[Joey Minta]

Patch checked in.

Comment 3

[gekacheka]

Above patch causes regression: removed calendarEvent.js, which provided
getCurrentNextOrPreviousRecurrence, which is used in unifinder.js and
mouseoverPreviews.js

Error: getCurrentNextOrPreviousRecurrence is not defined
Source File: chrome://calendar/content/mouseoverPreviews.js
Line: 257

Comment 4

[gekacheka]

Attachment: move getCurrentNextOrPreviousRecurrence to calendarUtils.js from deleted calendarEvent.js

(patch -l -p 2 -i file.patch)

Moved to calendarUtils since used in multiple places.

Mouseover works again in unifinder search results.

Comment 5

[Joey Minta]

Comment on attachment 193431 [details] [diff] [review]
move getCurrentNextOrPreviousRecurrence to calendarUtils.js from deleted calendarEvent.js

getCurrentNextOrPreviousRecurrence currently has the style of calendarEvent.js.
 Can you see what you can do about bringing the style of the function more in
line with what's already in calendarUtils.js?  Specifically:
-4 space indents
-use if (foo) instead of if( foo )
-use foo(bar) instead of foo( bar )
-put the opening { of an if on the same line
-avoid excessive double-spacing

Comment 6

[gekacheka]

Attachment: move getCurrentNextOrPreviousRecurrence to calendarUtils.js from deleted calendarEvent.js

(patch -l -p 2 -i file.patch)

As before, respaced and indented as requested.

(fixes regression: Mouseover events in unifinder displays again.)

Comment 7

[Joey Minta]

Comment on attachment 193501 [details] [diff] [review]
move getCurrentNextOrPreviousRecurrence to calendarUtils.js from deleted calendarEvent.js

For future reference, I've been told "if (foo) {" with a space between f and (.

r=jminta

Comment 8

[Joey Minta]

Patch checked in.