Closed Bug 304531 Opened 18 years ago Closed 18 years ago

event.target.rel has no properties (Port fix from bug 225854)

Categories

(Toolkit :: XUL Widgets, defect)

Product:
Toolkit
Component:
XUL Widgets
Version:
1.8 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8.1

People

(Reporter: philor, Assigned: philor)

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

patch v1
1.26 KB, patch
mconnor
: first-review+
Details | Diff | Splinter Review 
Looks like Firefox's feedview trips the bug 225854 problem of having
tabbrowser.xml's onLinkAdded wind up looking at the original document rather
than the transform, giving "event.target.rel has no properties" errors. Not
surprisingly, the same "event.originalTarget.rel" fix works fine.
Attached patch patch v1 — — Splinter Review 

        Attachment #192581 -
        Flags: first-review?(neil.parkwaycc.co.uk)

    
    

    
  
Comment on attachment 192581 [details] [diff] [review]
patch v1

I don't think I should be reviewing a port of my own patch...

        Attachment #192581 -
        Flags: first-review?(neil.parkwaycc.co.uk)

    
    

    
  
Comment on attachment 192581 [details] [diff] [review]
patch v1

'kay, I'll shop around.

        Attachment #192581 -
        Flags: first-review?(mconnor)

    
    

    
  
This happens with any pretty-printed XML document, such as
http://www.squarefree.com/turing/clickToView.xml.

        Attachment #192581 -
        Flags: first-review?(mconnor) → first-review+
Whiteboard: [checkin needed]

    
    

    
  
Trunk:
mozilla/toolkit/content/widgets/tabbrowser.xml; new revision: 1.110;
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → mozilla1.9alpha1

    
    

    
  
mozilla/toolkit/content/widgets/tabbrowser.xml 	1.103.2.24
Keywords: fixed1.8.1
Target Milestone: mozilla1.9alpha1 → mozilla1.8.1
Version: unspecified → 1.8 Branch

          You need to log in
          before you can comment on or make changes to this bug.