304565 - Changing a bookmark's description changes all descriptions of bookmarks if they previously had them

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Daniel Aleksandersen]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050715 Camino/0.9a2
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050715 Camino/0.9a2

I was just editing a description for ONE of my bookmarks and then they all
changed. Don't know why, when or what the f*, but they all changed. See a
screenshot of my bookmarkslist (as soon as I noted that once I changed on
bookmarks description, they all changed).

Can't reproduce.

Reproducible: Couldn't Reproduce

Steps to Reproduce:

Comment 1

[Daniel Aleksandersen]

Screenshot at http://img280.imageshack.us/my.php?image=version200507150809a21kc.png

Comment 2

[Samuel Sidler (old account; do not CC)]

I can confirm this behavior.

Steps to reproduce:
1. Create a description in one of your bookmarks
2. Go and create a description in another bookmark (closing the panel when finished)
  -> At this point, you should see all your descriptions disappear
3. Create a third description in a third bookmark (closing the panel when finished)
  -> You should see all the bookmark descriptions *reappear* but all with the
same description. 

This isn't hard to reproduce, but it can cause major dataloss.

This must be a regression, when did it happen?

Targeting for 0.9, upping to "blocker" and CCing Simon/Bruce.

Comment 3

[Samuel Sidler (old account; do not CC)]

Updating summary... longer but more reflective of what's going on.

Comment 4

[Simon Fraser [no longer active]]

Weird.

Comment 5

[Simon Fraser [no longer active]]

This happens because when you change the description of a bookmark via the info
panel, the bookmark gets the address of the mutable string storage of the
NSTextView; we need to make a copy.

Comment 6

[Simon Fraser [no longer active]]

Fixed on trunk and branch.

Comment 7

[Bill Gianopoulos [:WG9s]]

(In reply to comment #6)
> Fixed on trunk and branch.

Bonsai does not seem to show a trunk check-in for this.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #7)
> (In reply to comment #6)
> > Fixed on trunk and branch.
> 
> Bonsai does not seem to show a trunk check-in for this.

http://tinyurl.com/akwh3 shows checkins for both.  Check that your bonsai query
leaves the "Branch" field empty to see both branch and trunk checkins.

Comment 9

[Samuel Sidler (old account; do not CC)]

Attachment: Patch for 1.7 Branch

This is a patch for the 1.7 branch.

Note that these changes aren't necessary because this issue didn't actually exist on that branch, so this was more for fun than anything else (and because I just realized that the bug didn't exist). Since it is code cleanup, it'd be nice to have, but again, not necessary.

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 213555 [details] [diff] [review]
Patch for 1.7 Branch

This doesn't build.  Since the bug doesn't actually exist in 0.8.4 (ooops), we'll drop this from the list.