304643 - Mac: Font used in Preferences dialog is too small

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Uri Bernstein]

The font used exclusively in the "preferences" dialog (in Pinstripe) is the
"small system font" (which should be used just for "additional information about
settings", according to the Apple HIG).

The primary font used in dialogs should be the (larger) System Font. This is
what all OS X applications that I've checked (including Safari and Camino) use.

Comment 1

[Asaf Romano (gone)]

-> Kevin.

Comment 2

[Mike Schroepfer]

Won't block for beta - but would take a patch.

Comment 3

[Uri Bernstein]

Attachment: patch for Firefox

Notes:

1. This patch is only for Firefox, but the change to global.css will affect
Thunderbird as well. The proper changes have to be made to Thunderbird's
preferences.css (and possibly preferences.dtd) so that it won't break (I
currently don't have a thunderbird-configured CVS, so I couldn't manage doing
it myself).

2. Changing the prefwindow font made the dialog, whose width is specified in
ems, much wider. This had the positive side effect of fixing bug 304605, but
made the dialog somewhat unbalanced, IMO. So I countered it by reducing the
width from 47em to 44em in preferences.dtd.

3. There are two strings which are currently marked as <description>, but
arguably shouldn't be: 
- In Advanced|General: "Choose Languages web pages are displayed in".
- In Advanced|Security: "When a web site requires a certificate:".

Comment 4

[Uri Bernstein]

Attachment: screenshot

Screenshots of a sample tab:
Current (left), patched (right). (I tried to include the corresponding Safari
dialog as well, but that made the PNG too large for Bugzilla).

Comment 5

[Asaf Romano (gone)]

Comment on attachment 192940 [details] [diff] [review]
patch for Firefox

You need to ask a review form a browser/toolkit peer.

Comment 6

[Asaf Romano (gone)]

Comment on attachment 192940 [details] [diff] [review]
patch for Firefox

This is obsolete now.

Comment 7

[Kevin Gerich]

Attachment: toolkit/themes/pinstripe/global/icons/question-mark.png

part 1/2

Comment 8

[Kevin Gerich]

Attachment: Adds font:-moz-dialog and makes spacing adjustments. also adds a new help button.

2/2

fixes bug 306166 too.

Mano, can you please give this a look?

Comment 9

[Kevin Gerich]

Attachment: Screenshot of new styles. Thanks Uri!

Comment 10

[Asaf Romano (gone)]

Comment on attachment 194261 [details] [diff] [review]
Adds font:-moz-dialog and makes spacing adjustments. also adds a new help button.

First thing: no focus feedback on the new help button? I prefer a outline: fix,
but if that doesn't work well, let's hardcode it as an image, eek.

Note that we now do expose focus on nomral button, so that's a regression.

Also, while there is no place we would want to use it right now, there should
be a disabled state image as well (but that can wait).

Comment 11

[Asaf Romano (gone)]

Comment on attachment 194261 [details] [diff] [review]
Adds font:-moz-dialog and makes spacing adjustments. also adds a new help button.

Also:
1) The text under "Connection Settings" (General pane) is too small
2) Ditto for the text above the tabs in the Privacy pane, IMO.
3) Please replace line endings in this file with unix line endings.

Comment 12

[Asaf Romano (gone)]

Comment on attachment 194261 [details] [diff] [review]
Adds font:-moz-dialog and makes spacing adjustments. also adds a new help button.

"for the orginating web site only" has to remain a sub-checkbox of "Load
Images".

Comment 13

[Kevin Gerich]

Attachment: Pref cleanup patch, second try

Should fix all the issues raised

Comment 14

[Asaf Romano (gone)]

Comment on attachment 194270 [details] [diff] [review]
Pref cleanup patch, second try

You really want to place the "Expections" button in the same line with "Load
Images".

r=mano with that fixed.

Comment 15

[Asaf Romano (gone)]

Renominating since this is now a regression.

Comment 16

[Kevin Gerich]

Checked in on trunk and branch

Comment 17

[Asaf Romano (gone)]

fwiw, the "Exceptions" button is only almost in the same line with "Load Images".