304799 - when closing the Profile Manager with "Exit", the "Don't ask at startup" checkbox state isn't saved

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Thorsten 'nightrat' Fritz]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20050815 Firefox/1.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20050815 Firefox/1.0+

Starting the profilemanager of Sunbird. Unchecking "Don't ask at startup" has no
effect. Next time starting Sunbird the profilemanager does not appear and
Sunbird starts directly.

Reproducible: Always

Steps to Reproduce:
1.Start profilemanager
2.Unchecking "Don't ask at startup"
3.Close profilemanager
4.Start Sunbird

Actual Results:  
Sunbird starts directly without showing the profilemanager

Expected Results:  
Profilemanager should start

Comment 1

[Joey Minta]

Reporter:
   What version of Sunbird are you using?  (This can be found in the Help->About
window).  If you're not using a nightly build, can you please test there also.

Comment 2

[Thorsten 'nightrat' Fritz]

I use a trunk build.
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20050815 Mozilla
Sunbird/0.2+

Comment 3

[Joey Minta]

Confirmed.  The 'Don't ask at startup' checkbox properly remembers the value,
but the profile manager does not startup each time after it is unchecked.

This could be a toolkit problem, or a problem with our implementation of it. 
I'm not sure, so I'm leaving it as Calendar-General for now.

Comment 4

[Simon Paquet [:sipaq]]

Thorsten, can you please check whether this also happens on Firefox or
Thunderbird nightly trunk builds. If yes, then this is a general profile manager
bug and should be moved to Toolkit -> XRE Startup.

Comment 5

[Thorsten 'nightrat' Fritz]

Ok, i tested it on trunk builds of Firefox and Thunderbird. The same behaviour,
no profile manager opens.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

The "Exit" button is re-titled cancel button, so it doesn't cause changes to be saved... I guess it should.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Not really an XRE Startup bug, but I don't really see a better component for it...

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I run into the same problem today while testing a trunk build on another pc. At first I wanted to create an additional profile with fx2.0.0.9 before running the trunk build. I unchecked the box and hit exit. Starting Minefield afterwards the default profile was used. Damn!!

Also if we only have renamed the button the preference should be saved each time. If you just want to change the pref it's annoying that you have to start Firefox.

The changed setting is only saved within acceptDialog and not on exit:
http://mxr.mozilla.org/seamonkey/source/toolkit/profile/content/profileSelection.js#142

That's why flushing the profileService doesn't save it:
http://mxr.mozilla.org/seamonkey/source/toolkit/xre/nsAppRunner.cpp#1747
http://mxr.mozilla.org/seamonkey/source/toolkit/profile/src/nsToolkitProfileService.cpp#752

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1: Save startup prefs on exit

Comment 10

[Reed Loden [:reed]]

Checking in toolkit/profile/content/profileSelection.js;
/cvsroot/mozilla/toolkit/profile/content/profileSelection.js,v  <--  profileSelection.js
new revision: 1.14; previous revision: 1.13
done
Checking in toolkit/profile/content/profileSelection.xul;
/cvsroot/mozilla/toolkit/profile/content/profileSelection.xul,v  <--  profileSelection.xul
new revision: 1.10; previous revision: 1.9
done

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b2pre) Gecko/2007111318 Minefield/3.0b2pre