when closing the Profile Manager with "Exit", the "Don't ask at startup" checkbox state isn't saved

VERIFIED FIXED in mozilla1.9beta2

Status

()

VERIFIED FIXED
13 years ago
10 years ago

People

(Reporter: thorsten.fritz, Assigned: whimboo)

Tracking

Trunk
mozilla1.9beta2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

13 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20050815 Firefox/1.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20050815 Firefox/1.0+

Starting the profilemanager of Sunbird. Unchecking "Don't ask at startup" has no
effect. Next time starting Sunbird the profilemanager does not appear and
Sunbird starts directly.

Reproducible: Always

Steps to Reproduce:
1.Start profilemanager
2.Unchecking "Don't ask at startup"
3.Close profilemanager
4.Start Sunbird

Actual Results:  
Sunbird starts directly without showing the profilemanager

Expected Results:  
Profilemanager should start
(Reporter)

Updated

13 years ago
Version: unspecified → Trunk

Comment 1

13 years ago
Reporter:
   What version of Sunbird are you using?  (This can be found in the Help->About
window).  If you're not using a nightly build, can you please test there also.
(Reporter)

Comment 2

13 years ago
I use a trunk build.
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20050815 Mozilla
Sunbird/0.2+

Comment 3

13 years ago
Confirmed.  The 'Don't ask at startup' checkbox properly remembers the value,
but the profile manager does not startup each time after it is unchecked.

This could be a toolkit problem, or a problem with our implementation of it. 
I'm not sure, so I'm leaving it as Calendar-General for now.
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 4

13 years ago
Thorsten, can you please check whether this also happens on Firefox or
Thunderbird nightly trunk builds. If yes, then this is a general profile manager
bug and should be moved to Toolkit -> XRE Startup.
(Reporter)

Comment 5

13 years ago
Ok, i tested it on trunk builds of Firefox and Thunderbird. The same behaviour,
no profile manager opens.

Updated

13 years ago
Assignee: mostafah → nobody
Component: General → XRE Startup
Product: Calendar → Toolkit
QA Contact: general → nobody
Version: Trunk → unspecified
The "Exit" button is re-titled cancel button, so it doesn't cause changes to be saved... I guess it should.
Not really an XRE Startup bug, but I don't really see a better component for it...
OS: Linux → All
Hardware: PC → All
Summary: Unchecking "Don't ask at startup" has no effect → when closing the Profile Manager with "Exit", the "Don't ask at startup" checkbox state isn't saved
(Assignee)

Comment 8

11 years ago
I run into the same problem today while testing a trunk build on another pc. At first I wanted to create an additional profile with fx2.0.0.9 before running the trunk build. I unchecked the box and hit exit. Starting Minefield afterwards the default profile was used. Damn!!

Also if we only have renamed the button the preference should be saved each time. If you just want to change the pref it's annoying that you have to start Firefox.

The changed setting is only saved within acceptDialog and not on exit:
http://mxr.mozilla.org/seamonkey/source/toolkit/profile/content/profileSelection.js#142

That's why flushing the profileService doesn't save it:
http://mxr.mozilla.org/seamonkey/source/toolkit/xre/nsAppRunner.cpp#1747
http://mxr.mozilla.org/seamonkey/source/toolkit/profile/src/nsToolkitProfileService.cpp#752
QA Contact: nobody → xre.startup
Version: unspecified → Trunk
(Assignee)

Comment 9

11 years ago
Created attachment 287845 [details] [diff] [review]
Patch v1: Save startup prefs on exit
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Attachment #287845 - Flags: review?
(Assignee)

Updated

11 years ago
Attachment #287845 - Flags: review? → review?(benjamin)

Updated

11 years ago
Attachment #287845 - Flags: review?(benjamin) → review+
(Assignee)

Updated

11 years ago
Attachment #287845 - Flags: approval1.9?

Updated

11 years ago
Attachment #287845 - Flags: approval1.9? → approval1.9+
(Assignee)

Updated

11 years ago
Keywords: checkin-needed
Checking in toolkit/profile/content/profileSelection.js;
/cvsroot/mozilla/toolkit/profile/content/profileSelection.js,v  <--  profileSelection.js
new revision: 1.14; previous revision: 1.13
done
Checking in toolkit/profile/content/profileSelection.xul;
/cvsroot/mozilla/toolkit/profile/content/profileSelection.xul,v  <--  profileSelection.xul
new revision: 1.10; previous revision: 1.9
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M10
(Assignee)

Comment 11

11 years ago
Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b2pre) Gecko/2007111318 Minefield/3.0b2pre
Status: RESOLVED → VERIFIED
No longer depends on: 403724
Depends on: 403724

Updated

10 years ago
Component: XRE Startup → Startup and Profile System
QA Contact: xre.startup → startup
You need to log in before you can comment on or make changes to this bug.