30480 - [RFE] add 'show dependencies as buglist' link to showdependencytree.cgi

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, enhancement, P3)

Description

[selmer (gone)]

While I like the dependency tree I can get by going to the parent bug, it's 
missing a lot of stuff that's necessary for bug management.  I'd like to be able 
to get a normal query result page for all the bugs dependent on the named parent 
bug.  It would be OK if this were a link on the parent bug next to the existing 
link for the dependency tree.

This enhancement would take the place of the current procedure of:

go to parent bug, 
scroll down to dependency list,
copy bug list from text edit field to clipboard,
go to query page,
scroll down to "only" bugs field,
paste list into the text field,
submit query.

The other alternative is ugly, painful pseudo-keywords in the summary so you can 
query on the summary line.  Setting this up is difficult and error prone since 
you must visit every bug and summaries sometimes get changed by others.

Comment 1

[Matthew Tuck [:CodeMachine]]

Funny, I was going to submit this soon when I saw it.  

I don't know how you can have bugs "dependent on the named parent bug", I would
expect they would be depended on by the "parent" bug, but anyway, this would
probably be useful in both directions.

With this you could quickly perform a bulk change on the depended on bugs.  I
wanted this when trying to convert a tracking bug of mine to a keyword.  Out of
interest, are bulk changes what you would use it for selmer, or something else?

Comment 2

[selmer (gone)]

Bulk change is an important usage.

I also need to generate the list of dependent bugs for project tracking purposes 
and the dependency list isn't as flexible as the query result list.  In 
particular, I need a list that includes the status whiteboard.  I also use other 
standard columns that may differ from most users because they're convenient in 
my bug management.  Rather than attempt to embelish the dependency list, I'd 
like to get the dependent bugs into a query result page.

Actually, I'd also like to be able to choose the dependency tree format for an 
arbitrary list of bugs.  This would avoid some artificial levels of meta bugs 
that only refer to other meta bugs.

Comment 3

[selmer (gone)]

I just noticed that the boolean generator now has depends attributes in it.  
However, when I tried to use it I got an error page complaining that "blocked" 
is not a known attribute to query against.

Comment 4

[Matthew Tuck [:CodeMachine]]

Dependency tree of list -> bug #12992.

Comment 5

[Terry Weissman]

[e-mail] is the new owner of Bugzilla and Bonsai.  (For details,
see my posting in netscape.public.mozilla.webtools,
news://news.mozilla.org/38F5D90D.F40E8C1A%40geocast.com .)

Comment 6

[Gervase Markham [:gerv]]

This bug has not been touched for more than nine months. In most cases, that 
means it has "slipped through the net". Please could the owner take a moment to 
add a comment to the bug with current status, and/or close it.

Thank you :-)

Gerv

Comment 7

[Asa Dotzler [:asa]]

so now you can get a nice list of bugs that would be in the dependency tree by
doing a query for OtherBugsDependingOnThis equal to <bug numer> where the bug
number is the blocked bug.  

Comment 8

[timeless]

Attachment: long links

Comment 9

[selmer (gone)]

Could that link be added next to the "Show dependency tree" link on the form? 
Maybe call it "Show dependencies as query" or something.  Maybe we don't need
the tree or graph views anymore (did anyone ever use the graph anyway?)

Comment 10

[Christopher Aillon (sabbatical, not receiving bugmail)]

Mass moving to new product Bugzilla...

Comment 11

[Asa Dotzler [:asa]]

updating summary (please reverse if I've got this wrong)

old summary: Query page needs way to show dependent bug list

new summary: [RFE] add 'show dependencies as buglist' link to query.cgi and
showdependencytree.cgi

Comment 12

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Comment 13

[Gervase Markham [:gerv]]

I ported timeless' patch to the new showdependencytree.cgi. I think this would
be really useful when managing large dependency lists, such as the Mozilla 1.0
list. It automatically takes into account any changes to the data display
(hiding bugs etc.).

CCing myk, as I intend to nominate this bug for getting in before the Bugzilla
upgrade.

Gerv

Comment 14

[Gervase Markham [:gerv]]

Attachment: Patch v.2

Comment 15

[Dave Miller [:justdave]]

Comment on attachment 53502 [details] [diff] [review]
Patch v.2

this fails if either there are no deps or are no blockers (but not both)

Comment 16

[Gervase Markham [:gerv]]

Attachment: Patch v.3

Comment 17

[Dave Miller [:justdave]]

Comment on attachment 53523 [details] [diff] [review]
Patch v.3

r= justdave

Comment 18

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 53523 [details] [diff] [review]
Patch v.3

>+if ($blocked_size + $dependson_size) > 0) {

Syntax error, opening parenthesis needed.

>+    print '<p>View all ';
>+        '">blocker</a> | ';
>+        '">dependent</a> | ';
>+          '">related</a> bugs as a bug list.</p>';

This terminology is the inverse of that used above it on the page,
since the "blocker" link here refers to the list labelled "depends on"
above while the "dependent" link refers to the "blocks" list.
We should use the same terminology in both places.

Also, why not put the links next to the list titles?  i.e.:

BUGS THAT BUG 76722 DEPENDS ON (view as bug list)

Comment 19

[Gervase Markham [:gerv]]

Attachment: Patch v.4

Comment 20

[Gervase Markham [:gerv]]

Good idea. That actually simplifies that patch. It's pretty trivial now.
Requesting re-review from myk.

Gerv

Comment 21

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 53646 [details] [diff] [review]
Patch v.4

Looks good, except for now there is no way to get the entire list
of dependencies as a buglist.  PutHeader takes a third parameter
that it places to the right of the page header (in show_bug.cgi
this parameter displays the summary of the bug).  Perhaps a link
to entire bug list could be placed in this parameter (or something
else like this).

Comment 22

[Gervase Markham [:gerv]]

You could do that - although it would re-complicate the patch again. Will anyone
really want all the related bugs without caring whether they are blocked by or
blocking? Somehow, I doubt it. Let's try this, and if people ask for it, I'll do it.

Gerv

Comment 23

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 53646 [details] [diff] [review]
Patch v.4

Sounds good to me.  r=myk, and resetting status of latest patch.

Comment 24

[Christian Reis]

Gerv, can't you eliminate %seen altogether in that case? I don't care
too much for the optimization it offers and having an extra variable for
nothing.. well, think about it.

In any case, r=kiko. Thanks for taking that off my back :)

Comment 25

[Gervase Markham [:gerv]]

You can't eliminate %seen because %seen and %printed are not the same thing if
you are restricting what you are printing.

/cvsroot/mozilla/webtools/bugzilla/showdependencytree.cgi,v  <-- 
showdependencytree.cgi
new revision: 1.10; previous revision: 1.9

Gerv

Comment 26

[Christian Reis]

Gerv: one question. The old summary used to include "query.cgi" in it - was that
removed intentionally, and should another bug be created for it?

Comment 27

[Gervase Markham [:gerv]]

It was removed intentionally, because the patch doesn't cover it. And, as far as
I can see, a 'show dependencies as buglist' link makes no sense on query.cgi,
because query.cgi is not a bug, and doesn't have dependencies.

Gerv

Comment 28

[Asa Dotzler [:asa]]

Oops. When I changed the summary I meant to say "and show_bug.cgi" not
query.cgi. Right now we have two links in the dependency area on show_bug, one
to the tree view and one to the chart view. I meant to request a third link
there.  I've filed bug 105079

Comment 29

[Brant Gurganus]

[RFE] is deprecated in favor of severity: enhancement.  They have the same meaning.