Closed
Bug 304847
Opened 19 years ago
Closed 19 years ago
[FIX]nsSecurityBrowserUIImpl shouldn't GetName when it doesn't need to
Categories
(Core :: Security: PSM, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
(Keywords: fixed1.8.1, perf)
Attachments
(1 file)
|
1.40 KB,
patch
|
KaiE
:
review+
dmosedale
:
superreview+
KaiE
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
It only uses the name for NSPR logging, so it shouldn't get it when logging is not happening -- getting the name is expensive.
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #192838 -
Flags: superreview?(darin)
Attachment #192838 -
Flags: review?(kaie.bugs)
|
|
Assignee | |
Updated•19 years ago
|
Priority: -- → P2
Summary: nsSecurityBrowserUIImpl shouldn't GetName when it doesn't need to → [FIX]nsSecurityBrowserUIImpl shouldn't GetName when it doesn't need to
Target Milestone: --- → mozilla1.9alpha
|
|
Assignee | |
Updated•19 years ago
|
Attachment #192838 -
Flags: superreview?(darin) → superreview?(dmose)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 192838 [details] [diff] [review] Proposed patch sr=dmose
Attachment #192838 -
Flags: superreview?(dmose) → superreview+
|
||
Comment 3•19 years ago
|
||
Comment on attachment 192838 [details] [diff] [review] Proposed patch r=kaie
Attachment #192838 -
Flags: review?(kaie.bugs) → review+
|
|
Assignee | |
Comment 4•19 years ago
|
||
Fixed.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
|
||
Updated•19 years ago
|
Attachment #192838 -
Flags: branch-1.8.1+
You need to log in
before you can comment on or make changes to this bug.
Description
•