305096 - Schema Validation does not handle inheritance of simple types

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Doron Rosenberg (IBM)]

Currently, the code assumes that schema simpletypes inherit from builtin types.
 So xsd:restriction and unions/lists can only inherit from builtin types right now.

So for example, type Foo may restrict type Bar (say with an enumeration), which
itself restricts xsd:string.  So to validate against Foo,  we need to walk the
inheritance tree until we find something that isn't a restriction (builtin or
union/list).  As we walk, we store the restriction facets, making sure that once
we find a facet, we don't overwrite it with the same facet defined on an
inherited type.

Solution:

I added a nsSchemaDerivedSimpleType struct, which contains all possible facets
and a baseType member.  nsSchemaDerivedSimpleType gets passed around when needed
and added to.

Comment 1

[Doron Rosenberg (IBM)]

Attachment: patch

Comment 2

[Doron Rosenberg (IBM)]

peterv: could you take a look at this anytime soon?  We'd like this in 1.8,
since complex types won't make it I assume (too big of a patch).

I've verified it passes my testsuite and all, so no regressions.

Comment 3

[Doron Rosenberg (IBM)]

Comment on attachment 193180 [details] [diff] [review]
patch

going to check this in without review for time reason.

Comment 4

[Doron Rosenberg (IBM)]

checked into trunk

Comment 5

[Doron Rosenberg (IBM)]

Attachment: patch that doesn't break :)

Comment 6

[Doron Rosenberg (IBM)]

new patch checked in.

Comment 7

[Doron Rosenberg (IBM)]

checked into 1.8.1

Comment 8

[Doron Rosenberg (IBM)]

reopening since we need this on 1.8.0.x

Comment 9

[Doron Rosenberg (IBM)]

fixed on 1.8.0.2