305239 - Text is entered invisible and backwards into <textarea> after pressing END

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jerry Baker]

20050818 trunk

STEP TO REPRODUCE:

1. Place your cursor into the textarea in this bug report (DESCRIPTION).
2. Press DEL then END then ENTER.
3. Now type something.

RESULT:

You will see nothing as you type. Press reload and you will see everything you
typed ... BACKWARDS!

Comment 1

[Jerry Baker]

You have to type a character first, so modify step two to say:

"Type any key, then press DEL then END then ENTER."

Comment 2

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050819
Firefox/1.0+ ID:2005081911

WFM (Branch)

Comment 3

[Dave Townsend [:mossop]]

I can reproduce this. One thing to note is that I found the input cursor seemed
to vanish. After clicking away then back to the textbox I could type normally
again, though the input cursor still didnt flash and any text I had entered and
not seen was still there and gets submitted with the text (see my bizarre
comment at the end of bug 305232)

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050819
Firefox/1.6a1 ID:2005081907

Comment 4

[Jerry Baker]

That's how I discovered this thing. I posted a message to a Web message board
and all the stuff I thought was not there was posted ... and backwards.

Comment 5

[Jerry Baker]

Reduced steps to reproduce:

1. Place cursor in textarea of this bug (DESCRIPTION).
2. Type any letter and then press END.
3. Type some more.

Comment 6

[Brendan Eich [:brendan]]

mrbkap, this bug is dying for you to fix it! ;-)

/be

Comment 7

[Dave Townsend [:mossop]]

There are situations other than pressing END that trigger this. I haven't
managed to reproduce one, but I almost never use the END key but today I have
hit this bug 3/4 times.

Comment 8

[Boris Zbarsky [:bzbarsky]]

This is a regression from bug 16311.  And it's not Firefox-specific; I have no
idea why this bug was filed in this product.

Comment 9

[Blake Kaplan (:mrbkap) (inactive)]

Passing onto Uri since it's his regression.

Comment 10

[Hermann Schwab]

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.9a1) Gecko/20050819 SeaMonkey/1.0a
happened to me in Bug 305181 comment 10
Suddenly I noticed some stuff I had zyped wasn't seen, I repositioned the
cursor, went on, looked if the lost stuff was somewhere else, and submitted.

When I was looking next, I found junk at the end of the comment, seems to be the
lost characters read RTL.

ravitca sediseb ,liamg)c2w( 

Comment 11

[Uri Bernstein]

Attachment: patch

Restore the code in nsFrame::DrillDownToEndOfLine() which ensures that a
BRFrame will not be returned (unless it's the only frame on the line).

This also makes the change to nsSelection::GetFrameForNodeOffset() (which I
added in the final version of the 16311 patch) unnecessary, so reverted it.

I have no idea how this slipped by me when I tested the original patch. I'll
try to be more careful in the future.

Comment 12

[Uri Bernstein]

*** Bug 305183 has been marked as a duplicate of this bug. ***

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 14

[u88484]

Not completely fixed with following steps...reproduced a few times by users on
mozillazine forums.

To reproduce put focus/cursor into a textarea (Quick Reply here for example),
hit enter, hit end, type something and hit refresh

Comment 15

[TimoT]

This still happens on 20050822 build (win32).

1. Put cursor into a textarea
2. Hit Enter
3. Hit End (cursor disappears at this point)
4. Type something (nothing seems to happen)
5. Hit Reload (text you typed appears backwards)

Comment 16

[Uri Bernstein]

Right - I just discovered this myself. Pressing END on a blank line still
creates the problem. I'm working on a fix, but this is a bit tricky.

Comment 17

[Uri Bernstein]

... and pressing HOME on a blank line has the same effect.

Comment 18

[Ryuichi KUBUKI]

Seeing it in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1)
Gecko/20050822 Firefox/1.6a1 with these steps

>1. Place your cursor into the textarea in this bug report (DESCRIPTION).
>2. Press DEL then END then ENTER.
>3. Now type something.

Comment 19

[Uri Bernstein]

Attachment: patch for blank lines

If the frame we really want to be in isn't a text frame (but is, say, a
BRFrame), don't return it as the mResultContent (with mContentOffset=0), but
instead return its parent content, with the appropreate offset to the content
itself.

This emulates the behaviour of the original code in this case.

And also set the hint to PR_TRUE because otherwise it's wrong. (sorry, i wish I
had a better explanation for this part).

Comment 20

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in. I forgot what Uri's comment was so I wrote my own.