305254 - make c-sdk support parallel builds on windows msvc

Status: RESOLVED WONTFIX

(Directory :: LDAP C SDK, defect)

Description

[Chase Phillips]

On Windows builds, the current c-sdk code doesn't use the rules.mk magic to
write symbol information to a separate .pdb file per compiled file.  Any project
which relies on the c-sdk can't build via parallel make.  If possible, make
c-sdk support parallel builds.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

This should be easy, assuming it's not already fixed on the trunk... see bug 286179.

Comment 2

[Mark Smith [:mcs]]

It looks like this should be as simple as adding a /PDB: option to CFLAGS inside
configure.  I don't know how to initiate a parallel build using MSVC though.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Do you actually need to initiate it from inside MSVC?  If not, "make -j2" or
something similar from the command-line should do the trick, regardless of what
compiler is being used under the hood.

Comment 4

[Chase Phillips]

(In reply to comment #2)
> It looks like this should be as simple as adding a /PDB: option to CFLAGS inside
> configure.

Yes, that should do it.  The main rules.mk supports parallel makes by tweaking
the -PDB: option.  See http://lxr.mozilla.org/mozilla/source/config/rules.mk#172
for the code which makes this happen.

(In reply to comment #3)
> Do you actually need to initiate it from inside MSVC?  If not, "make -j2" or
> something similar from the command-line should do the trick, regardless of what
> compiler is being used under the hood.

Yup, adding the following line to your mozconfig will turn on parallel make:

  mk_add_options MOZ_MAKE_FLAGS="-j2"

Comment 5

[Rich Megginson]

So, is there something we need to do to the Mozilla ldap code on the trunk?  Has this been fixed on any of the mozilla/seamonkey/tbird development branches?

Looks like the current trunk uses -PDB:NONE (and the latest free MSVC compiler complains that this is no longer supported).

BTW, I've got the entire build working using the free MSVC+SDK+cygwin.  I'd like to get this fixed while I'm visiting this area of the code.

Comment 6

[Rich Megginson]

How does this relate to bug 232600?

Comment 7

[Mark Smith [:mcs]]

(In reply to comment #6)
> How does this relate to bug 232600?

Seems like the solution will be related.  As far as I know, this has not been fixed anywhere.

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

(In reply to comment #5)
> Has this been fixed on any of the mozilla/seamonkey/tbird development 
> branches?

No.

Comment 9

[Ping Chen [:rnons] (away)]

LDAP c-sdk has been removed in bug 1729862.