305361 - install-global-extension and install-global-theme work inconsistently

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

The functions used by install-global-extension and install-global-theme use the
same functions that are used during an interactive install and often provide
inconsistent results... often the item is staged which will require an
interactive session with rights to the app location to complete the install. For
1.5 these command line flags should expand the xpi/jar into the app extensions
directory or they should be removed entirely. Patch coming up.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

This extracts the extension or theme into the app extensions dir and then
upgrades its chrome. This has essentially the same end result as extracting an
extension or theme into the app extensions dir and then launching once to
upgrade the chrome if necessary so other users on the system can use the
extension or theme.

These command line args are rather broken currently on the branch and I think
this should be considered for 1.8b4. One example
       if (globalTheme) {
-	 var file = commandLine.resolveFile(globalExtension);

Comment 2

[Benjamin Smedberg]

We should either take this (rather simple) patch, or remove the "-install-*"
flags completely.

Comment 3

[Robert Strong (they/them - no direct email)]

Fixed on trunk - leaving open for possible 1.8b4 approval

Comment 4

[Robert Strong (they/them - no direct email)]

Fixed on trunk and MOZILLA_1_8_BRANCH