Closed
Bug 305384
Opened 18 years ago
Closed 18 years ago
Alerts service not built on non-Win32 platforms (port toolkit fix)
Categories
(SeaMonkey :: UI Design, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jens.b, Assigned: jens.b)
References
Details
(Keywords: fixed1.8)
Attachments
(2 files, 1 obsolete file)
548 bytes,
patch
|
roc
:
review+
roc
:
superreview+
asa
:
approval1.8b5+
|
Details | Diff | Splinter Review |
9.66 KB,
patch
|
jens.b
:
review+
jens.b
:
superreview+
asa
:
approval1.8b5+
|
Details | Diff | Splinter Review |
See bug 305375 - the fix must be ported to XPFE because the alerts code is forked. I'll do this once the code is reviewed.
Assignee | ||
Comment 1•18 years ago
|
||
Port of the toolkit changes. - Alerts service IDL is now always built. - Alerts implementation is only built on windows, gtk1 and gtk2. - JS tweaks to make alerts work with gtk (no 0-pixel-height windows) and look good Both the download manager and its preferences page automatically detect whether the service is built, so no changes neccessary there.
Assignee | ||
Updated•18 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•18 years ago
|
||
Comment on attachment 196407 [details] [diff] [review] patch Neil: Reading SeaMonkey's review-and-flags document, I'm not quite sure whether this qualifies as a real UI change and needs sr - but I think you'll probably want to do both r/sr yourself then, anyway.
Attachment #196407 -
Flags: review?(neil.parkwaycc.co.uk)
Comment 3•18 years ago
|
||
Comment on attachment 196407 [details] [diff] [review] patch >+ var windowDim = document.documentElement.boxObject; Nit: unused variable
Attachment #196407 -
Flags: review?(neil.parkwaycc.co.uk) → review+
Comment 4•18 years ago
|
||
This brings GTK1's handling of small windows in to line with GTK2 i.e. don't resize small windows, just don't display them.
Attachment #196909 -
Flags: superreview?(roc)
Attachment #196909 -
Flags: review?(roc)
Assignee | ||
Comment 5•18 years ago
|
||
Carrying over previous patch's r= as sr=neil plus r=bsmedberg from original toolkit patch.
Attachment #196407 -
Attachment is obsolete: true
Attachment #196942 -
Flags: superreview+
Attachment #196942 -
Flags: review+
Comment 6•18 years ago
|
||
Checking in xpfe/components/alerts/Makefile.in; /cvsroot/mozilla/xpfe/components/alerts/Makefile.in,v <-- Makefile.in new revision: 1.4; previous revision: 1.3 done Checking in xpfe/components/alerts/resources/content/alert.js; /cvsroot/mozilla/xpfe/components/alerts/resources/content/alert.js,v <-- alert.js new revision: 1.6; previous revision: 1.5 done Checking in xpfe/components/build/Makefile.in; /cvsroot/mozilla/xpfe/components/build/Makefile.in,v <-- Makefile.in new revision: 1.70; previous revision: 1.69 done Checking in xpfe/components/build/nsModule.cpp; /cvsroot/mozilla/xpfe/components/build/nsModule.cpp,v <-- nsModule.cpp new revision: 1.54; previous revision: 1.53 done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•18 years ago
|
||
Comment on attachment 196942 [details] [diff] [review] patch v2 I'd like to have this on the branch. It's a straight port of toolkit bug 305375 which got approved, too. Summary: No UI change, very low risk (only makefile changes plus small JS tweaks), high value for XULRunner/Extension developers, lets gtk users optionally enable download alerts via the existing pref.
Attachment #196942 -
Flags: approval1.8b5?
Updated•18 years ago
|
Attachment #196942 -
Flags: approval1.8b5? → approval1.8b5+
Comment 8•18 years ago
|
||
1.8 branch: Checking in components/alerts/Makefile.in; /cvsroot/mozilla/xpfe/components/alerts/Makefile.in,v <-- Makefile.in new revision: 1.3.20.1; previous revision: 1.3 done Checking in components/alerts/resources/content/alert.js; /cvsroot/mozilla/xpfe/components/alerts/resources/content/alert.js,v <-- alert.js new revision: 1.5.20.1; previous revision: 1.5 done Checking in components/build/Makefile.in; /cvsroot/mozilla/xpfe/components/build/Makefile.in,v <-- Makefile.in new revision: 1.69.8.1; previous revision: 1.69 done Checking in components/build/nsModule.cpp; /cvsroot/mozilla/xpfe/components/build/nsModule.cpp,v <-- nsModule.cpp new revision: 1.53.8.1; previous revision: 1.53 done
Keywords: fixed1.8
Attachment #196909 -
Flags: superreview?(roc)
Attachment #196909 -
Flags: superreview+
Attachment #196909 -
Flags: review?(roc)
Attachment #196909 -
Flags: review+
Comment 9•18 years ago
|
||
Comment on attachment 196909 [details] [diff] [review] GTK1 tweak (checked in trunk and branch) Seeking approval for low risk platform specific code (not used by official mozilla.org releases).
Attachment #196909 -
Flags: approval1.8b5?
Updated•18 years ago
|
Attachment #196909 -
Flags: approval1.8b5? → approval1.8b5+
Updated•18 years ago
|
Attachment #196909 -
Attachment description: GTK1 tweak → GTK1 tweak (checked in trunk and branch)
Assignee | ||
Comment 10•18 years ago
|
||
See also bug 310900.
You need to log in
before you can comment on or make changes to this bug.
Description
•