Closed Bug 305388 Opened 16 years ago Closed 12 years ago

place "later" button in same position

Categories

(Toolkit :: Application Update, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla1.9.1b2

People

(Reporter: Peter6, Assigned: robert.strong.bugs)

References

Details

(Keywords: polish)

Attachments

(2 files)

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050821
Firefox/1.0+ ID:2005082100

Different windows of the Software Update dialog show the [later] button on a
different place.
Attached image screenshot
Attached patch patchSplinter Review
This patch fixes the positioning of the 'later' button.
Attachment #199781 - Flags: review?(bugs)
Keywords: polish
Attachment #199781 - Flags: review?(bugs) → review?(darin)
I think this is probably something not worth blocking the release for, and I
would prefer to have Ben approve this change.  He's away until Monday.

This patch also does not apply to the latest trunk version of the code.
Flags: blocking1.8rc1?
Attachment #199781 - Flags: review?(darin) → review?(beng)
agreed. not a blocker.
Flags: blocking1.8rc1? → blocking1.8rc1-
OS: Windows 2000 → All
Hardware: PC → All
Since this is a pretty minor change I'm wondering if I set the flags right... Should this go in 1.8.0.1 or aviary2?
Aviary2, 1.8.0.1 is all about reliability, not UI twiddling.
Comment on attachment 199781 [details] [diff] [review]
patch

Comment 3 says it doesn't apply to trunk, and that was in 2005, and ben's not reviewing anymore, so removing the review request.
Attachment #199781 - Flags: review?(beng)
Version: 1.5.0.x Branch → Trunk
Product: Firefox → Toolkit
This will be fixed by bug 324121
Assignee: nobody → robert.bugzilla
Blocks: 324121
Fixed by the checkin of bug 324121.
No longer blocks: 324121
Status: NEW → RESOLVED
Closed: 12 years ago
Depends on: 324121
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b2
You need to log in before you can comment on or make changes to this bug.