Closed Bug 305389 Opened 16 years ago Closed 13 years ago

Either do or don't include angle quotation marks in software update buttons


(Toolkit :: Application Update, defect)

Not set





(Reporter: Peter6, Assigned: robert.strong.bugs)



(Keywords: polish)


(1 file, 2 obsolete files)

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050821
Firefox/1.0+ ID:2005082100

Different windows of the Software Update dialog have/don't have » (angle
quotation marks) in the button text.
Attached image screenshot
Back also uses "<" which is inconsistent.
Attached patch Gets rid of >> (obsolete) — Splinter Review
This gets rid of the >>
Keywords: polish
Attachment #193630 - Flags: review?(bugs) → review?(darin)
I believe the angle brackets are meant to indicate the start of a wizard
progression.  This UI paradigm is used in a bunch of Google web applications for
example.  I wouldn't be surprised if Ben (Goodger) picked up the paradigm from
there.  Personally, I think the current code is okay, but I defer to Ben on this
Attachment #193630 - Flags: review?(darin) → review?(beng)
Attached patch Fix v.1 (obsolete) — Splinter Review
Much as I like using someone else's quotation marks as decoration... um, that's not much. According to Wikipedia, there's ~35 languages whose speakers, when using an en-US build, see these guillemeted buttons as saying [Download & Install Now"]. Plus, implying it's a wizard isn't particularly appropriate, since you're not going through several screens of information gathering followed by a final [do it] button.
Assignee: nobody → philringnalda
Attachment #193630 - Attachment is obsolete: true
Attachment #260804 - Flags: ui-review?(beltzner)
Attachment #193630 - Flags: review?(beng)
OS: Windows 2000 → All
Hardware: PC → All
Target Milestone: --- → Firefox 3 alpha4
Version: 1.5.0.x Branch → Trunk
Fun question inspired by bug 373623 comment 23 and on - what happens with a screen reader that's using inflection to reflect punctuation when it sees that stray double (low angle) quote? What happens if we have both, spread across back and forward buttons so that [<<Back] [Forward>>] looks like the equivalent of a quoted "Back Forward"?
Comment on attachment 260804 [details] [diff] [review]
Fix v.1

Grr. Except, it is a wizard, practically for the user in some rare circumstances, and always as far as the code which gets "< Back" from the default, per-platform, Windows-only, wizard strings.
Attachment #260804 - Attachment is obsolete: true
Attachment #260804 - Flags: ui-review?(beltzner)
Target Milestone: Firefox 3 alpha4 → Firefox 3 beta1
Assignee: philringnalda → nobody
Target Milestone: Firefox 3 beta1 → ---
Product: Firefox → Toolkit
This is fixed by bug 324121
Assignee: nobody → robert.bugzilla
Depends on: 324121
Fixed by the checkin of bug 324121
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b2
You need to log in before you can comment on or make changes to this bug.