305389 - Either do or don't include angle quotation marks in software update buttons

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050821
Firefox/1.0+ ID:2005082100

Different windows of the Software Update dialog have/don't have » (angle
quotation marks) in the button text.

Comment 1

[Peter van der Woude [:Peter6]]

Attachment: screenshot

Comment 2

[Ben Basson]

Back also uses "<" which is inconsistent.

Comment 3

[Shayne Jewers]

Attachment: Gets rid of >>

This gets rid of the >>

Comment 4

[Darin Fisher]

I believe the angle brackets are meant to indicate the start of a wizard
progression.  This UI paradigm is used in a bunch of Google web applications for
example.  I wouldn't be surprised if Ben (Goodger) picked up the paradigm from
there.  Personally, I think the current code is okay, but I defer to Ben on this
one.

Comment 5

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

Much as I like using someone else's quotation marks as decoration... um, that's not much. According to Wikipedia, there's ~35 languages whose speakers, when using an en-US build, see these guillemeted buttons as saying [Download & Install Now"]. Plus, implying it's a wizard isn't particularly appropriate, since you're not going through several screens of information gathering followed by a final [do it] button.

Comment 6

[Phil Ringnalda (:philor)]

Fun question inspired by bug 373623 comment 23 and on - what happens with a screen reader that's using inflection to reflect punctuation when it sees that stray double (low angle) quote? What happens if we have both, spread across back and forward buttons so that [<<Back] [Forward>>] looks like the equivalent of a quoted "Back Forward"?

Comment 7

[Phil Ringnalda (:philor)]

Comment on attachment 260804 [details] [diff] [review]
Fix v.1

Grr. Except, it is a wizard, practically for the user in some rare circumstances, and always as far as the code which gets "< Back" from the default, per-platform, Windows-only, wizard strings.

Comment 8

[Robert Strong (they/them - no direct email)]

This is fixed by bug 324121

Comment 9

[Robert Strong (they/them - no direct email)]

Fixed by the checkin of bug 324121