305393 - Overlay in chrome.manifest fails with URL containing a search string

Status: RESOLVED WONTFIX

(Toolkit :: Startup and Profile System, defect)

Description

[Rod Whiteley]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.9a1) Gecko/20050820 Mozilla Sunbird/0.2+

When an application opens a XUL file using a URL with a search string, and the
file has an overlay specified in chrome.manifest, then the overlay is not applied.

For example:

  overlay chrome://something/content/file.xul chrome://extension/content/overlay.xul

fails when you use the URL:

  chrome://something/content/file.xul?a=b


Reproducible: Always

Steps to Reproduce:
1. Make an extension that overlays a XUL file.
2. Open the XUL file using a search string in the URL.

Actual Results:  
There is no overlay.

Expected Results:  
The overlay should work even with a search string in the URL.

You can work around this by specifying every possible search string in
chrome.manifest (but of course this does not happen when chrome.manifest is
generated from contents.rdf).

For example, a search string can be used by an extension that has its own
options page, to make the Extension Manager context menu Options choice open to
the correct page.  This is just an example.  Other uses of search strings should
be supported.

Comment 1

[Dave Townsend [:mossop]]

I saw this when trying to overlay the firefox extension manager.

Comment 2

[Benjamin Smedberg]

This is by design (perhaps unfortunately, but oh well). We use the entire URL
(include hash!) to search for overlays. To overlay the extension manager you
will need to add the type=foo to your overlay URL (and use a separate
instruction if you want to overlay the theme manager also).