305524 - Move frame recursion protection into docshell

Status: NEW

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

At the moment, our frame recursion protection is done in the frame loader.  We
should really consider just doing it in the docshell instead; that way it'll be
impossible to circumvent it by setting the location of the window or document in
the frame...

I _am_ a little worried that this might break some sites, but it would also help
prevent situations like bug 303163

Comment 1

[Josh Matthews [:jdm]]

Relevant files/methods:
http://mxr.mozilla.org/mozilla-central/source/content/base/src/nsFrameLoader.cpp - CheckForRecursiveLoad
http://mxr.mozilla.org/mozilla-central/source/docshell/base/nsDocShell.cpp

Comment 2

[MikeLing]

Hi I am interested in working on this bug,but it's my first time to work on with debug,can anybody guide me on how to get started with it?Thanks a lot.

Comment 3

[Josh Matthews [:jdm]]

If you haven't built Firefox yet, you should do that: https://developer.mozilla.org/en/Simple_Firefox_build. Once that's done, you should take a look at nsFrameLoader.cpp and find the method I referred to in comment 1.

Comment 4

[MikeLing]

(In reply to Josh Matthews [:jdm] from comment #3)
well，I found I can't build on windows but It's find in my Ubuntu,Is that still ok?

Comment 5

[Josh Matthews [:jdm]]

Yes.

Comment 6

[MikeLing]

(In reply to Josh Matthews [:jdm] from comment #5)
> Yes.

Sir, I must sorry to tell you I don't know which kind of method in nsFrameLoader.cpp should I check out after I read the link in Comment 1. Could you tell me more detail? Thank you very much :)

Comment 7

[Boris Zbarsky [:bzbarsky]]

You want the CheckForRecursiveLoad method.

Comment 8

[MikeLing]

(In reply to Boris Zbarsky (:bz) from comment #7)
> You want the CheckForRecursiveLoad method.

I find it already,what should I do next?

Comment 9

[Hussam Al-Tayeb]

(In reply to MikeLing from comment #8)
> (In reply to Boris Zbarsky (:bz) from comment #7)
> > You want the CheckForRecursiveLoad method.
> 
> I find it already,what should I do next?

You could try the channel #introduction on irc.mozilla.org

Comment 10

[MikeLing]

(In reply to Hussam Al-Tayeb from comment #9)
Thanks :)

Comment 11

[C Jab]

Hi, I would like to work on this bug, but I do not know where to get started as this is my first time.

Comment 12

[Boris Zbarsky [:bzbarsky]]

C Jab, see comment 3 in this bug.  If you have that done, see comment 7, and if you're still not sure what to do, email me or comment here, please.