Open
Bug 305524
Opened 19 years ago
Updated 2 years ago
Move frame recursion protection into docshell
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
NEW
People
(Reporter: bzbarsky, Unassigned)
References
Details
(Keywords: helpwanted, student-project)
At the moment, our frame recursion protection is done in the frame loader. We should really consider just doing it in the docshell instead; that way it'll be impossible to circumvent it by setting the location of the window or document in the frame... I _am_ a little worried that this might break some sites, but it would also help prevent situations like bug 303163
![]() |
Reporter | |
Updated•19 years ago
|
Priority: -- → P3
Target Milestone: --- → mozilla1.9alpha
Updated•15 years ago
|
QA Contact: ian → general
![]() |
Reporter | |
Updated•14 years ago
|
Assignee: bzbarsky → nobody
Keywords: helpwanted,
student-project
Priority: P3 → --
Target Milestone: mozilla1.9alpha1 → ---
Comment 1•12 years ago
|
||
Relevant files/methods: http://mxr.mozilla.org/mozilla-central/source/content/base/src/nsFrameLoader.cpp - CheckForRecursiveLoad http://mxr.mozilla.org/mozilla-central/source/docshell/base/nsDocShell.cpp
Hi I am interested in working on this bug,but it's my first time to work on with debug,can anybody guide me on how to get started with it?Thanks a lot.
Comment 3•11 years ago
|
||
If you haven't built Firefox yet, you should do that: https://developer.mozilla.org/en/Simple_Firefox_build. Once that's done, you should take a look at nsFrameLoader.cpp and find the method I referred to in comment 1.
(In reply to Josh Matthews [:jdm] from comment #3) well,I found I can't build on windows but It's find in my Ubuntu,Is that still ok?
Comment 5•11 years ago
|
||
Yes.
(In reply to Josh Matthews [:jdm] from comment #5) > Yes. Sir, I must sorry to tell you I don't know which kind of method in nsFrameLoader.cpp should I check out after I read the link in Comment 1. Could you tell me more detail? Thank you very much :)
![]() |
Reporter | |
Comment 7•11 years ago
|
||
You want the CheckForRecursiveLoad method.
(In reply to Boris Zbarsky (:bz) from comment #7) > You want the CheckForRecursiveLoad method. I find it already,what should I do next?
Comment 9•11 years ago
|
||
(In reply to MikeLing from comment #8) > (In reply to Boris Zbarsky (:bz) from comment #7) > > You want the CheckForRecursiveLoad method. > > I find it already,what should I do next? You could try the channel #introduction on irc.mozilla.org
Comment 10•11 years ago
|
||
(In reply to Hussam Al-Tayeb from comment #9) Thanks :)
Comment 11•9 years ago
|
||
Hi, I would like to work on this bug, but I do not know where to get started as this is my first time.
![]() |
Reporter | |
Comment 12•9 years ago
|
||
C Jab, see comment 3 in this bug. If you have that done, see comment 7, and if you're still not sure what to do, email me or comment here, please.
Assignee | ||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•