305581 - Implement nsTraceRefCnt on Mac OS X

Status: RESOLVED WORKSFORME

(Core :: XPCOM, defect)

Description

[Simon Fraser [no longer active]]

We need to have nsTraceRefCnt working on Mac OS X so that we can debug XPCOM leaks.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

There's a reasonable chance that the Linux ifdefs in nsStackFrameUnix could work
with very little modification.  That said, dladdr seems to be strongly
deprecated on Mac OS X (#warning in the header file).

Comment 2

[Simon Fraser [no longer active]]

Apple have some code for stack walking and symbol lookup (in the More Is Better
sample) that I've adopted. I'll also need to drop in some C++ demangling code
from the gcc tree. I have things mostly working.

Comment 3

[Simon Fraser [no longer active]]

Attachment: Patch

I added nsStackFrameDarwin.h/cpp for the Mac OS X code. It contains a bunch of
code based on Apple sample code for stack walking and symbol lookup, to which I
added a basic PC->symbol cache. I believe it's OK for us to include the
modified Apple code; here is the license:

	Copyright:	Copyright (c) 2003 by Apple Computer, Inc., All Rights
Reserved.

	Disclaimer:	IMPORTANT:  This Apple software is supplied to you by
Apple Computer, Inc.
				("Apple") in consideration of your agreement to
the following terms, and your
				use, installation, modification or
redistribution of this Apple software
				constitutes acceptance of these terms.	If you
do not agree with these terms,
				please do not use, install, modify or
redistribute this Apple software.

				In consideration of your agreement to abide by
the following terms, and subject
				to these terms, Apple grants you a personal,
non-exclusive license, under Apple’s
				copyrights in this original Apple software (the
"Apple Software"), to use,
				reproduce, modify and redistribute the Apple
Software, with or without
				modifications, in source and/or binary forms;
provided that if you redistribute
				the Apple Software in its entirety and without
modifications, you must retain
				this notice and the following text and
disclaimers in all such redistributions of
				the Apple Software.  Neither the name,
trademarks, service marks or logos of
				Apple Computer, Inc. may be used to endorse or
promote products derived from the
				Apple Software without specific prior written
permission from Apple.	Except as
				expressly stated in this notice, no other
rights or licenses, express or implied,
				are granted by Apple herein, including but not
limited to any patent rights that
				may be infringed by your derivative works or by
other works in which the Apple
				Software may be incorporated.

				The Apple Software is provided by Apple on an
"AS IS" basis.	APPLE MAKES NO
				WARRANTIES, EXPRESS OR IMPLIED, INCLUDING
WITHOUT LIMITATION THE IMPLIED
				WARRANTIES OF NON-INFRINGEMENT, MERCHANTABILITY
AND FITNESS FOR A PARTICULAR
				PURPOSE, REGARDING THE APPLE SOFTWARE OR ITS
USE AND OPERATION ALONE OR IN
				COMBINATION WITH YOUR PRODUCTS.

				IN NO EVENT SHALL APPLE BE LIABLE FOR ANY
SPECIAL, INDIRECT, INCIDENTAL OR
				CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
LIMITED TO, PROCUREMENT OF SUBSTITUTE
				GOODS OR SERVICES; LOSS OF USE, DATA, OR
PROFITS; OR BUSINESS INTERRUPTION)
				ARISING IN ANY WAY OUT OF THE USE,
REPRODUCTION, MODIFICATION AND/OR DISTRIBUTION
				OF THE APPLE SOFTWARE, HOWEVER CAUSED AND
WHETHER UNDER THEORY OF CONTRACT, TORT
				(INCLUDING NEGLIGENCE), STRICT LIABILITY OR
OTHERWISE, EVEN IF APPLE HAS BEEN
				ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

For what it's worth, the sample in question is:
http://developer.apple.com/samplecode/MoreIsBetter/listing83.html

Comment 5

[Simon Fraser [no longer active]]

maybe dup to bug 336517?

Comment 6

[Jesse Ruderman]

WFM.  trace-refcnt has been working on Mac for a long time.