305610 - Bouncing sidebar when dragging it wider

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Ria Klaassen (not reading all bugmail)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050823 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050823 Firefox/1.6a1

When I want to change the sidebar's width with my mouse, the sidebar bounces
unwillingly.

This behaviour changed very recently:

Working build: 1.9a1_2005082210
Failing build: 1.9a1_2005082222 

Reproducible: Always

Steps to Reproduce:
1. Open the history or bookmarks sidebar
2. Try dragging it wider

Comment 1

[Ria Klaassen (not reading all bugmail)]

Not in branch.

Comment 2

[Martijn Wargers (dead)]

This sounds just like a regression from fixing bug 296036.
I haven't checked this myself yet, so can't confirm yet.

Comment 3

[Eli Friedman]

Yes, I'm pretty sure this is my fault.  I messed up in nsSplitterFrame.cpp. 
I'll have a patch up later today.

Comment 4

[Eli Friedman]

Attachment: Patch

This slipped through my testing.  The coordinate system of the splitter itself
shifts around when dragging, so the coordinates need to be calculated in terms
of the parent box.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 193598 [details] [diff] [review]
Patch

Thanks Eli! I'll land it.

We need to think about getting you CVS access :-)

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in.