305910 - Open in tabs should have more intuitive title

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Ivan Ičin]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050824 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050824 Firefox/1.0+

Open in tabs is very useful option, but I think that its title may confuse
users. Now that "Bookmark all Tabs" is added to menu, it should be probably
called "Open All in Tabs".

Reproducible: Always

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

I don't think that this is so important as to block FFx 1.5, but if someone can
whip up a simple patch, it'd be worth looking at.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: makes changes in command label and comments

Trivial change to the command label (and update to the comments). This only changes the code in the bookmarks component, not the places component. Let me know if you want me to make a patch that changes it there, too.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/bookmarks/content/bookmarksMenu.js 	1.56
mozilla/browser/locales/en-US/chrome/browser/bookmarks/bookmarks.properties 	1.15

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Is this something that we want to land for b2?

Comment 5

[Mike Connor [:mconnor]]

not a blocker, but we'll likely take the patch

Comment 6

[Axel Hecht [:Pike]]

This change isn't reflected in a key change, is that intentional? I think that this is a UI-consistency issue that localizers have hardly done themselves.

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 225383 [details] [diff] [review]
makes changes in command label and comments

a=mconnor on behalf of drivers for checkin by Wednesday, July 19th

Comment 8

[Mike Connor [:mconnor]]

How do we know whether localizers have or have not done things with consistent phrasing?  This doesn't look like a semantic change to me, since its just using clearer language.  Hopefully localizers have already done that...

Comment 9

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/bookmarks/content/bookmarksMenu.js 	1.48.2.9
mozilla/browser/locales/en-US/chrome/browser/bookmarks/bookmarks.properties 	1.12.2.3

Comment 10

[Axel Hecht [:Pike]]

(In reply to comment #8)
> How do we know whether localizers have or have not done things with consistent
> phrasing?  This doesn't look like a semantic change to me, since its just using
> clearer language.  Hopefully localizers have already done that...
> 

Guessing roughly from an l10n checkout from before this landing on the 1.8 branch, your chances are 2-3 out of 54. Post to .l10n at least?