305920 - update manager incorrectly reports download speed

Status: RESOLVED INCOMPLETE

(Toolkit :: Application Update, defect)

Description

[Gary Elshaw]

Update Manager incorrectly reports download speed after clicking the hide button
and bringing it back into the foreground. In my case, on dialup, the update
correctly reports download speed (usually 5k a second). After hiding the window
using the hide button and bringing the update manager back to the foreground, i
am downloading at 160k a second. Yes, that would be nice if it were true.

Steps to reproduce:

1. Begin download using Software Update.
2. Click the Hide button.
3. Bring Update Manager to the foreground.
4. Update Manager reports 'connecting to server'.
5. Update Manager reports an inflated download speed and then (over several
minutes) correctly reports download speed.

What should happen:

Update Manager should correctly report download speed whether hidden or not.

Comment 1

[Jo Hermans]

bug 245725 probably

*** This bug has been marked as a duplicate of 245725 ***

Comment 2

[Gary Elshaw]

bug 245725 is for the download manager, this is for the new software update manager.

Comment 3

[Jo Hermans]

it could use the same algorithm ...

Comment 4

[Gary Elshaw]

Maybe, but i can't replicate the same behaviour or result. Hiding a download
manager window is not possible in the same way as the update manager, and the
download manager doesn't renegotiate with a server in the same way as hiding the
update manager. Also, it's maybe worth keeping in mind that the update manager's
functionality is quite different. I'll cc Zach into this, hopefully he'll set us
both straight.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

The download manager and update downloading code is seperate. The update code
does it's own status formatting, that would be where the bug is in this case.

See
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/mozapps/update/content/updates.js&rev=1.47#777

Comment 6

[Andreas Morawietz]

I can reproduce this behaviour, too.

If I hide software-update and cick on it again, it showed a transfer-rate of
over 6 Mbytes per Second - but I've only  t-com DSL1000. :)

Comment 7

[Robert Strong (they/them - no direct email)]

With the landing of bug 414326 for Firefox 3.1 we now use the same mechanism for displaying download speed but we use nsIIncrementalDownload so this might not be fixed by bug 414326.

Comment 8

[Robert Strong (they/them - no direct email)]

Can someone check if this is still reproducible with either a Minefield (e.g.
mozilla-central) or Shiretoko (e.g. mozilla-1.9.1) nightly? Thanks
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/

Comment 9

[Robert Strong (they/them - no direct email)]

I believe this was fixed per comment #7. No response to comment #8 so resolving -> incomplete