The default bug view has changed. See this FAQ.

Height:0% is not the same as height:0px inside a table

RESOLVED FIXED in mozilla1.8beta5

Status

()

Core
Layout: Tables
RESOLVED FIXED
12 years ago
10 years ago

People

(Reporter: Martijn Wargers (dead), Assigned: Bernd)

Tracking

({fixed1.8, testcase})

Trunk
mozilla1.8beta5
x86
Windows XP
fixed1.8, testcase
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.8b5 +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

12 years ago
See upcoming testcase.
Both tables and button inside it are identical, only the first has height:0% and
the second has height:0px.
They should render the same, but they don't.

I saw this when looking at distrowatch.com.

bz	{#developers} mw22: oh, tables....
bz	{#developers} mw22: hrm... file a bug? ;)
bz	{#developers} mw22: and make sure to cc bernd...
(Reporter)

Comment 1

12 years ago
Created attachment 193855 [details]
testcase

The bug can also be seen in Mozilla1.7.

Comment 2

12 years ago
Is this feature any part of the "Acid 2" test?
(Assignee)

Comment 3

12 years ago
the percent height observer stuff is obviously not limited to quirks mode as it
should be. The questions is only where to cut it.
(Assignee)

Comment 4

12 years ago
Created attachment 194052 [details] [diff] [review]
patch

cut it at the cell level where it seems to start.
Assignee: nobody → bernd_mozilla
Status: NEW → ASSIGNED
(Assignee)

Comment 5

12 years ago
>Both tables and button inside it are identical, only the first has height:0% and
>the second has height:0px.
>They should render the same, but they don't.
They should not render identical in standards mode a percentage base height
inside auto height becomes itself auto. So its height: auto vs 0px.
(Reporter)

Comment 6

12 years ago
Ah, I see. So the patch seems to fix http://www.distrowatch.com broken layout
(because distrowatch is in standards mode).
The mentioning of the broken layout at distrowatch.com (buttons and stuff
overflowing table cells) was here:
http://forums.mozillazine.org/viewtopic.php?p=1704044
(Assignee)

Updated

12 years ago
Attachment #194052 - Flags: superreview?(bzbarsky)
Attachment #194052 - Flags: review?(bzbarsky)
Attachment #194052 - Flags: superreview?(bzbarsky)
Attachment #194052 - Flags: superreview+
Attachment #194052 - Flags: review?(bzbarsky)
Attachment #194052 - Flags: review+

Comment 7

12 years ago
Maybe this should be chosen for the branch. If it is  not a risky patch, then
please nominate it. 
(Assignee)

Comment 8

12 years ago
fix checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Comment 9

12 years ago
"The set of bugs blocking beta1 is tracked by the blocking1.8b4 flag . This list
is the set of bugs which truly have to be done before a more public release.
These are large/risky patches, common crashes, or break commonly used websites."
http://developer.mozilla.org/devnews/index.php/2005/08/30/9-days-untill-15-beta/

This would seem to fit in the "broken commonly used websites" (assuming that is
what they meant to say) category, could this possibly be checked into the branch?

Updated

12 years ago
Flags: blocking1.8b5?

Comment 10

12 years ago
bernd, bz, is this branch worthy?
Comment on attachment 194052 [details] [diff] [review]
patch

I believe it is, yes.  This makes a table quirk only happen in quirks mode. 
Only standards-mode stuff is affected, and probably only for the better.
Attachment #194052 - Flags: approval1.8b5?

Updated

12 years ago
Attachment #194052 - Flags: approval1.8b5? → approval1.8b5+
*** Bug 293372 has been marked as a duplicate of this bug. ***

Updated

12 years ago
Flags: blocking1.8b5? → blocking1.8b5+

Updated

12 years ago
Keywords: fixed1.8
Fixed on branch.
Target Milestone: --- → mozilla1.8beta5
Blocks: 271387
Depends on: 323459
You need to log in before you can comment on or make changes to this bug.