Closed Bug 305984 Opened 19 years ago Closed 19 years ago

Update the isFIPS information SSLCipherSuiteInfo table

Categories

(NSS :: Libraries, defect, P1)

Product:
NSS
Component:
Libraries
Version:
3.10
Platform:
x86
Solaris
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: glenbeasley, Assigned: glenbeasley)

Details

Attachments

(1 file, 2 obsolete files)

remove dead code and update FIPS value for cipher suites
6.10 KB, patch
Details | Diff | Splinter Review
Update the isFIPS information SSLCipherSuiteInfo table in sslinfo.c
set SSL_RSA_FIPS_WITH_DES_CBC_SHA to 0 since DES is not FIPS 140-2 SSL_RSA_FIPS_WITH_3DES_EDE_CBC_SHA is still marks as FIPS: marked the following ciphers for FIPS 140-2 TLS_DHE_RSA_WITH_AES_256_CBC_SHA TLS_DHE_DSS_WITH_AES_256_CBC_SHA TLS_RSA_WITH_AES_256_CBC_SHA TLS_DHE_RSA_WITH_AES_128_CBC_SHA TLS_DHE_DSS_WITH_AES_128_CBC_SHA TLS_RSA_WITH_AES_128_CBC_SHA SSL_DHE_RSA_WITH_3DES_EDE_CBC_SHA SSL_DHE_DSS_WITH_3DES_EDE_CBC_SHA SSL_RSA_WITH_3DES_EDE_CBC_SHA TLS_ECDH_ECDSA_WITH_3DES_EDE_CBC_SHA TLS_ECDH_ECDSA_WITH_AES_128_CBC_SHA TLS_ECDH_ECDSA_WITH_AES_256_CBC_SHA TLS_ECDH_RSA_WITH_3DES_EDE_CBC_SHA TLS_ECDH_RSA_WITH_AES_128_CBC_SHA TLS_ECDH_RSA_WITH_AES_256_CBC_SHA TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA
Attachment #193949 - Flags: superreview?(wtchang)
Attachment #193949 - Flags: review?(rrelyea)
Comment on attachment 193949 [details] [diff] [review] update FIPS value for cipher suites Glen, you changed the wrong field. The isFIPS field is the third from last field of the SSLCipherSuiteInfo structure. You changed the last field, which is the nonStandard field. Please generate the new patch using cvs diff -u.
Attachment #193949 - Flags: superreview?(wtchang)
Attachment #193949 - Flags: superreview-
Attachment #193949 - Flags: review?(rrelyea)
update FIPS value for cipher suites unmarked the following cipher suites because DES is not FIPS 140-2: SSL_RSA_FIPS_WITH_DES_CBC_SHA SSL_RSA_WITH_DES_CBC_SHA TLS_RSA_EXPORT1024_WITH_DES_CBC_SHA marked the following cipher suites for FIPS 140-2 TLS_DHE_RSA_WITH_AES_256_CBC_SHA TLS_DHE_DSS_WITH_AES_256_CBC_SHA TLS_RSA_WITH_AES_256_CBC_SHA TLS_DHE_RSA_WITH_AES_128_CBC_SHA TLS_DHE_DSS_WITH_AES_128_CBC_SHA TLS_RSA_WITH_AES_128_CBC_SHA SSL_DHE_RSA_WITH_3DES_EDE_CBC_SHA SSL_DHE_DSS_WITH_3DES_EDE_CBC_SHA TLS_ECDH_ECDSA_WITH_3DES_EDE_CBC_SHA TLS_ECDH_ECDSA_WITH_AES_128_CBC_SHA TLS_ECDH_ECDSA_WITH_AES_256_CBC_SHA TLS_ECDH_RSA_WITH_3DES_EDE_CBC_SHA TLS_ECDH_RSA_WITH_AES_128_CBC_SHA TLS_ECDH_RSA_WITH_AES_256_CBC_SHA TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA Cipher suites already marked as FIPS: SSL_RSA_FIPS_WITH_3DES_EDE_CBC_SHA SSL_RSA_WITH_3DES_EDE_CBC_SHA
Attachment #193949 - Attachment is obsolete: true
Attachment #194262 - Flags: superreview?(wtchang)
Attachment #194262 - Flags: review?(rrelyea)
Comment on attachment 194262 [details] [diff] [review] update FIPS value for cipher suites (v2) There's and #ifdef 0 in the GetChannelInfo which sets an 'isFIPS' variable that should be removed while your are in the file (remove meaning 'remove the #ifdef 0 and all the code it ifdef's out', not 'remove the #ifdef to enable the code''. ) bob
Attachment #194262 - Flags: review?(rrelyea) → review+
Comment on attachment 194262 [details] [diff] [review] update FIPS value for cipher suites (v2) Here are the citations that support these changes. FIPS 140-2 Annex A says the following are approved security functions applicable to FIPS 140-2: - AES - DES and Triple-DES. Note: see below about DES. - DSA, RSA and ECDSA. In particular, RSASSA-PKCS1-v1_5 and RSASSA-PSS in PKCS #1 v2.1 are approved. - SHA-1, SHA-224, SHA-256, SHA-384, SHA-512 This NIST webpage http://www.itl.nist.gov/fipspubs/withdraw.htm says DES (FIPS 46-3) was withdrawn on May 19, 2005. See this Federal Register notice http://csrc.nist.gov/publications/fips/05-9945-DES-Withdrawl.pdf. FIPS 140-2 Annex D says the following key establishment techniques are *not* FIPS approved key establishment techniques but are allowed for use in a FIPS Approved mode. - Diffie-Hellman (key agreement) - EC Diffie-Hellman (key agreement) - Key Wrapping using asymmetric keys
Attachment #194262 - Flags: superreview?(wtchang) → superreview+
Nelson suggests that we also remove the two non-standard FIPS SSL cipher suites. This patch doesn't remove those two cipher suites although it marks the one using DES as non-FIPS. Nelson, could you explain how we remove a SSL cipher suite from NSS?
Priority: -- → P1
Target Milestone: --- → 3.11
Version: 3.11 → 3.10
Following Bob Comment # 4 I removed the #ifdef 0 and related dead code from getChannelInfo. /cvsroot/mozilla/security/nss/lib/ssl/sslinfo.c,v <-- sslinfo.c new revision: 1.13; previous revision: 1.12 done
Attachment #194262 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment on attachment 194262 [details] [diff] [review] update FIPS value for cipher suites (v2) Change attachment description to be unique
Attachment #194262 - Attachment description: update FIPS value for cipher suites → update FIPS value for cipher suites (v2)
In response to Comment 6 the two non-standard FIPS SSL cipher suites are marked as "non-standard" in the the sslinfo table, so applications can choose not to use these non-standard ciphers. For this reason we will not remove these ciphers for 3.11.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: