306148 - create new events with floating datetime

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

There are a few bugs that have to do with timezones, like wrong recurrance
calculations. I think we can work around those bugs by storing datetimes in
floating timezone, instead of utc. That is what 0.2 did, and that mostly worked.
If we can get most recurrance and views to work, we can try to ship a release
without having to switch to new views, which would delay the release even more.

(note: this won't fix the bugs i mentioned, it will only work around them. we
should store proper timezone information one day)

example bugs: bug 303826, bug 304084.

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

other bugs that might be timezone related, and fixing this could work around:
bug 305846 and bug 305847

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: patch v1

This patch makes all the dates from the event dialog to be floating.
I noticed that .jsDate on a floating datetime didn't work correctly. It worked
like the timezone was utc, not floating. To fix that, i made floating a special
case in .jsDate. dmose, can you review that part?

Comment 3

[Joey Minta]

Comment on attachment 194035 [details] [diff] [review]
patch v1

+function today()
+{

A useful function that I also need for bug 297934, but does it really belong in
this patch?  Unless there's a good reason, it probably shouldn't be here.

r=jminta, hoping this makes some of those bugs disappear

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 194035 [details] [diff] [review]
patch v1

r=dmose

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in