Closed Bug 306209 Opened 15 years ago Closed 15 years ago

Should fire NS_FOCUSCONTENT event on nsPluginInstanceOwner by clicking plugin's content

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

x86
Windows XP
defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla1.9alpha1

People

(Reporter: masayuki, Assigned: emk)

References

()

Details

Attachments

(3 files)

When object frame created child widget for plugin content, the events for plugin
conent is catching on nsPluginInstanceOwner class. This class has focus listner.
But this focus listner is fired by using keyborad tabbing. We click prugin content,
the event isn't fired. I need this event for advanced IME implementation(See bug
55751). Please help me.
Blocks: 55751
No longer blocks: 5571
Attached file testcase
If base widget of flash plugin has focus, you can show alert.
You can set focus by Keyborad only. You may not be able to set focus by mouse
click.
Assignee: events → VYV03354
Attached patch Patch rv1.0Splinter Review
When plug-in window clicked, the messages will be sent in the following order:
1. PluginWndProc
2. WndProc set by plug-ins
3. nsWindow::ProcessMessage
and NS_PLUGIN_ACTIVATE will be generated in nsWindow::ProcessMessage.
But some plug-ins (including Flash Player) won't forward messages to
nsWindow::ProcessMessage. Therefore I moved WM_MOUSEACTIVATE to PluginWndProc.
Attachment #194246 - Flags: superreview?(jst)
Attachment #194246 - Flags: review?(jst)
Status: NEW → ASSIGNED
*** Bug 243824 has been marked as a duplicate of this bug. ***
*** Bug 213466 has been marked as a duplicate of this bug. ***
I tested the patch, it works fine.
Comment on attachment 194246 [details] [diff] [review]
Patch rv1.0

roc:

Could you r+sr for this?
This blocks bug 55751.
I tested this patch. This patch works fine for me.
Attachment #194246 - Flags: superreview?(roc)
Attachment #194246 - Flags: superreview?(jst)
Attachment #194246 - Flags: review?(roc)
Attachment #194246 - Flags: review?(jst)
Comment on attachment 194246 [details] [diff] [review]
Patch rv1.0

This is a risky patch. Make sure it only lands on trunk!
Attachment #194246 - Flags: superreview?(roc)
Attachment #194246 - Flags: superreview+
Attachment #194246 - Flags: review?(roc)
Attachment #194246 - Flags: review+
checked-in. thank you.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha
Blocks: 323142
I'm proposing that we back out this fix because it has caused bug 323142 and reopen this bug.
Is it possible to fix this bug in a similar way to the way bug 317486 was fixed?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Ian:

Don't reopen this bug until the patch is backed out.
Status: REOPENED → RESOLVED
Closed: 15 years ago15 years ago
Resolution: --- → FIXED
We might need both handlers or something to satisfy all needs.
*** Bug 356554 has been marked as a duplicate of this bug. ***
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.