306209 - Should fire NS_FOCUSCONTENT event on nsPluginInstanceOwner by clicking plugin's content

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

When object frame created child widget for plugin content, the events for plugin
conent is catching on nsPluginInstanceOwner class. This class has focus listner.
But this focus listner is fired by using keyborad tabbing. We click prugin content,
the event isn't fired. I need this event for advanced IME implementation(See bug
55751). Please help me.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: testcase

If base widget of flash plugin has focus, you can show alert.
You can set focus by Keyborad only. You may not be able to set focus by mouse
click.

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: Patch rv1.0

When plug-in window clicked, the messages will be sent in the following order:
1. PluginWndProc
2. WndProc set by plug-ins
3. nsWindow::ProcessMessage
and NS_PLUGIN_ACTIVATE will be generated in nsWindow::ProcessMessage.
But some plug-ins (including Flash Player) won't forward messages to
nsWindow::ProcessMessage. Therefore I moved WM_MOUSEACTIVATE to PluginWndProc.

Comment 3

[Masatoshi Kimura [:emk]]

*** Bug 243824 has been marked as a duplicate of this bug. ***

Comment 4

[Masatoshi Kimura [:emk]]

*** Bug 213466 has been marked as a duplicate of this bug. ***

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I tested the patch, it works fine.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 194246 [details] [diff] [review]
Patch rv1.0

roc:

Could you r+sr for this?
This blocks bug 55751.
I tested this patch. This patch works fine for me.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 194246 [details] [diff] [review]
Patch rv1.0

This is a risky patch. Make sure it only lands on trunk!

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in. thank you.

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch for check-in

Comment 10

[Ian Neal]

I'm proposing that we back out this fix because it has caused bug 323142 and reopen this bug.
Is it possible to fix this bug in a similar way to the way bug 317486 was fixed?

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Ian:

Don't reopen this bug until the patch is backed out.

Comment 12

[Ere Maijala (slow)]

We might need both handlers or something to satisfy all needs.

Comment 13

[Phil Ringnalda (:philor)]

*** Bug 356554 has been marked as a duplicate of this bug. ***