306354 - xpi signature verification only looks in first chunk of data received

Status: RESOLVED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[Brian Ryner (not reading)]

XPInstall's CertReader is designed to buffer up to 32KB of data to look for 
the signature, but its OnDataAvailable always returns 
NS_ERROR_BINDING_ABORTED, which means that if the signature is not in the 
first chunk of data read off the network (which can be well under 1500 bytes 
for slower connections), the XPI is treated as unsigned.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

Comment 2

[Doug Turner (:dougt)]

when will the signature not be in the first 32k?

Comment 3

[Brian Ryner (not reading)]

(In reply to comment #2)
> when will the signature not be in the first 32k?

I think you misunderstood the bug.  The signature should always be in the 
first 32k.  The problem is that we may not have all the data we need for the 
signature in the first OnDataAvailable call.

Comment 4

[Doug Turner (:dougt)]

ah.  got it.

sounds fine with me.  I would just hope that we don't read any more than the
smallest amount required to fit a cert.

Comment 5

[Darin Fisher]

Comment on attachment 194209 [details] [diff] [review]
patch

r+sr=darin

Comment 6

[Brian Ryner (not reading)]

Comment on attachment 194209 [details] [diff] [review]
patch

Checked in on trunk... requesting approval for 1.8 branch, and I'd also like
this to be considered for the 1.0.7 release since it's a very safe fix and has
a high impact on extension authors who sign their XPIs.

Comment 7

[Chris Beard]

Comment on attachment 194209 [details] [diff] [review]
patch

approved for 1.8b4

Comment 8

[Brian Ryner (not reading)]

Fixed on MOZILLA_1_8_BRANCH

Comment 9

[Robert Strong (they/them - no direct email)]

*** Bug 297518 has been marked as a duplicate of this bug. ***

Comment 10

[Daniel Veditz [:dveditz]]

Comment on attachment 194209 [details] [diff] [review]
patch

not killing anyone on the old branch