306358 - Dragging and dropping of text in search bar gives js error.

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Martijn Wargers (dead)]

I get this error:
Error: this.mEnterEvent has no properties
Source File: chrome://browser/content/search.xml
Line: 307
And the search isn't working anymore.

I think this is a regression from bug 235204.

Comment 1

[Martijn Wargers (dead)]

Attachment: patch

This fixes it for me.

Comment 2

[Martijn Wargers (dead)]

This patch would make bug 304850 obsolete, by the way.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 194213 [details] [diff] [review]
patch

>Index: browser/base/content/search.xml

>+          var altKeyPressed = false;
>+          if (aEvent)
>+            this.mEnterEvent = aEvent;
>           SearchLoadURL(searchURL, this.mEnterEvent.altKey);

altKeyPressed isn't being used, and I think the equivalent of (aEvent ||
this.mEnterEvent).altKey would work just as well, without needing to set
mEnterEvent.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: comments addressed

Comment 5

[Asaf Romano (gone)]

Comment on attachment 194253 [details] [diff] [review]
comments addressed

r=mano.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Attachment: tweak

After thinking a little bit, I think this may be better, to deal with the case
of extension authors (like Paste and Go) who just call onTextEntered without an
event param.

Comment 7

[Asaf Romano (gone)]

Comment on attachment 194333 [details] [diff] [review]
tweak

makes sense, r=mano.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Fixed on trunk.

mozilla/browser/base/content/search.xml; new revision: 1.28;

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Fixed on the 1.8 branch by bug 235204.