[FIX]###!!! ASSERTION: Float frame has wrong parent: 'floatFrame->GetParent() == mBlock', file nsBlockReflowState.cpp, line 835

RESOLVED FIXED in mozilla1.9alpha1

Status

()

Product:
Core
Component:
Layout: Block and Inline
P1
normal
RESOLVED FIXED
Reported:
12 years ago
Modified:
10 years ago

People

(Reporter: mats, Assigned: bz)

Tracking

({testcase, verified1.8.1.13})

Version:
Trunk
Target:
mozilla1.9alpha1
x86
Linux
Keywords:
testcase, verified1.8.1.13
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

Testcase
606 bytes, text/html
Details
GDB data + stack
14.30 KB, text/plain
Details
Fix
1.56 KB, patch
roc
: review+
roc
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

•
12 years ago 
###!!! ASSERTION: Float frame has wrong parent: 'floatFrame->GetParent() ==
mBlock', file nsBlockReflowState.cpp, line 835

STEPS TO REPRODUCE
1. load the attached testcase
(Reporter)

Comment 1

•
12 years ago 
Created attachment 194416 [details]
Testcase
(Reporter)

Comment 2

•
12 years ago 
Created attachment 194452 [details]
GDB data + stack
(Assignee)

Comment 3

•
12 years ago 
Created attachment 205284 [details] [diff] [review]
Fix

Just have to get the right parent when initing the floating letter frame.

Note that this does not help with the fact that we show the first letter twice; not sure why that happens...
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #205284 - Flags: superreview?(roc)
Attachment #205284 - Flags: review?(roc)
 (Assignee)

Updated

•
12 years ago
Priority: -- → P1
Summary: ###!!! ASSERTION: Float frame has wrong parent: 'floatFrame->GetParent() == mBlock', file nsBlockReflowState.cpp, line 835 → [FIX]###!!! ASSERTION: Float frame has wrong parent: 'floatFrame->GetParent() == mBlock', file nsBlockReflowState.cpp, line 835
Target Milestone: --- → mozilla1.9alpha
Attachment #205284 - Flags: superreview?(roc)
Attachment #205284 - Flags: superreview+
Attachment #205284 - Flags: review?(roc)
Attachment #205284 - Flags: review+
 (Assignee)

Comment 4

•
12 years ago 
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Blocks: 415827
 (Reporter)

Comment 5

•
10 years ago 
The patch was merged to MOZILLA_1_8_BRANCH by bug 415827 so adding
fixed1.8.1.13 keyword.
Keywords: fixed1.8.1.13
Flags: in-testsuite?

Comment 6

•
10 years ago 
Verified fixed on the 1.8.1 branch. After updating my 1.8.1 debug build, I don't see the assertion anymore with the testcase.
Keywords: fixed1.8.1.13 → verified1.8.1.13
You need to log in before you can comment on or make changes to this bug.