306791 - SSO cookie bug for MW1.5rc4: cookie not registered by Safari or IE

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: General, defect)

Description

[Deb Richardson [:dria] (plz NEEDINFO)]

Polvi and I have run into a bizarre bug trying to get single-sign-on working in
MW1.5rc4

The two test sites are here:

http://developer.mozilla.org/test/docs/
http://developer.mozilla.org/test2/docs/

The SSO now works fine in DeerPark and Camino, but fails in Safari and IE.  As
far as I can tell, cookie(s) aren't getting set.  I've opened up the security
settings on both browsers to accept all cookies from everywhere, and it didn't
help. 

The strange part is that if I go to the current en/docs/ wiki and get a
PHPSESSID cookie there, I can login to the test/docs/ wikis _fine_ in both
browsers.  So there's something wrong with the MW1.5rc4 stuff that's trying to
set the cookies, but just for Safari and IE (I haven't tested Opera).

We had other related problems earlier, but I think Polvi got those sorted out.

Anyhow, if one or both of you could possibly take a look at the problem and code
(gandalf: we have a new MW repository where we're doing custom work...someone
(shaver or polvi) should be able to tell you how to access that code), I'd
appreciate it.

Comment 1

[Deb Richardson [:dria] (plz NEEDINFO)]

Shaver appears to have fixed this.  I've tested on IE, Camino, Safari, and
DeerPark and SSO now seems to work as expected.  Polvi, could you also test and
make sure that it works for you?  I'll double check everything after I get some
lunch.

I believe shaver checked the fixes in.

Comment 2

[Mike Shaver (:shaver emeritus)]

There was nothing to check in.  The error was introduced in the local copy of
DefaultSettings.php:

$wgCookieDomain = ' ';

(It should be '', which means that it doesn't set a domain, instead of setting a
meaningless one that confuses Safari and IE.)

I just reverted that change, once I found it.