I was playing around with getters and setters, and found that: foo getter Causes: Assertion failure: ts->lookahead == 0 || ON_CURRENT_LINE(ts, CURRENT_TOKEN(ts).pos), at jsscan.c:1052 This is because getting and ungetting newline tokens leaves the scanner in an inconsistent state (the EOL token ends up on the wrong line).
Created attachment 194636 [details] [diff] [review] fix the assertion No need to complicate other code and tax release build runtime, let's just fix the silly assertion. /be
This bug concerns a bogus assertion, something in DEBUG builds only. Fix likewise affects only DEBUG builds, so it's good for branch and trunk. /be
Simplest testcase that botches the assert is just 'getter\n'. /be
Assignee: general → brendan
Priority: -- → P2
Target Milestone: --- → mozilla1.8beta4
Comment on attachment 194636 [details] [diff] [review] fix the assertion Sure. r=mrbkap
Attachment #194636 - Flags: review?(mrbkap) → review+
Fixed, trunk and branch. /be
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Checking in regress-306794.js; /cvsroot/mozilla/js/tests/js1_5/Regress/regress-306794.js,v <-- regress-306794.js initial revision: 1.1 done To test this you need to run a debug build an check stdout|err.
verified fixed 1.8.x and trunk.
Status: RESOLVED → VERIFIED
Keywords: fixed1.8 → verified1.8
You need to log in before you can comment on or make changes to this bug.