306794 - Assertion parsing 'foo getter'

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[Blake Kaplan (:mrbkap) (inactive)]

I was playing around with getters and setters, and found that:
foo getter

Causes: Assertion failure: ts->lookahead == 0 || ON_CURRENT_LINE(ts,
CURRENT_TOKEN(ts).pos), at jsscan.c:1052

This is because getting and ungetting newline tokens leaves the scanner in an
inconsistent state (the EOL token ends up on the wrong line).

Comment 1

[Brendan Eich [:brendan]]

Attachment: fix the assertion

No need to complicate other code and tax release build runtime, let's just fix
the silly assertion.

/be

Comment 2

[Brendan Eich [:brendan]]

This bug concerns a bogus assertion, something in DEBUG builds only.  Fix
likewise affects only DEBUG builds, so it's good for branch and trunk.

/be

Comment 3

[Brendan Eich [:brendan]]

Simplest testcase that botches the assert is just 'getter\n'.

/be

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 194636 [details] [diff] [review]
fix the assertion

Sure. r=mrbkap

Comment 5

[Brendan Eich [:brendan]]

Fixed, trunk and branch.

/be

Comment 6

[Bob Clary [:bc] (inactive)]

Checking in regress-306794.js;
/cvsroot/mozilla/js/tests/js1_5/Regress/regress-306794.js,v  <--  regress-306794.js
initial revision: 1.1
done

To test this you need to run a debug build an check stdout|err.

Comment 7

[Bob Clary [:bc] (inactive)]

verified fixed 1.8.x and trunk.