Closed
Bug 306862
Opened 19 years ago
Closed 19 years ago
session history should flush content viewers on memory-pressure notification
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
People
(Reporter: bryner, Assigned: bryner)
References
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
|
1.53 KB,
patch
|
marria
:
review+
darin.moz
:
approval1.8.1+
|
Details | Diff | Splinter Review |
When the memory-pressure notification is sent through the observer service,
session history should evict all cached content viewers to free up memory.
|
Assignee | |
Updated•19 years ago
|
Flags: blocking1.8b5?
|
||
Comment 1•19 years ago
|
||
Will eval for 1.8b5 once we see the level of risk for the patch.
|
|
||
Comment 2•19 years ago
|
||
Bryner - are you working on this for b2?
|
||
Comment 3•19 years ago
|
||
I believe bryner is working on bug 292965 right now. When that's fixed, we
should get him to tell us more about this bug.
|
||
Comment 4•19 years ago
|
||
Please renominate if a patch appears for this, but the lack of visible action
makes this a non-blocker for now.
Flags: blocking1.8b5? → blocking1.8b5-
|
||
Updated•19 years ago
|
Blocks: blazinglyfastback
|
||
Updated•19 years ago
|
Flags: blocking1.8.1?
|
|
||
Comment 5•19 years ago
|
||
Bryner - will we have any chance for this in 1.8.1?
Flags: blocking1.8.1? → blocking1.8.1+
|
|
Assignee | |
Comment 6•19 years ago
|
||
Sure, this should be really easy
|
|
Assignee | |
Comment 7•19 years ago
|
||
Attachment #226538 -
Flags: review?(marria)
|
||
Comment 8•19 years ago
|
||
Comment on attachment 226538 [details] [diff] [review]
patch (against MOZILLA_1_8_BRANCH)
weird, when i view this attachment as diff it says the file is at mozilla/xpfe/cxpfe/components/shistory/src/nsSHistory.cpp
Attachment #226538 -
Flags: review?(marria) → review+
|
|
Assignee | |
Comment 9•19 years ago
|
||
(In reply to comment #8)
> (From update of attachment 226538 [details] [diff] [review] [edit])
> weird, when i view this attachment as diff it says the file is at
> mozilla/xpfe/cxpfe/components/shistory/src/nsSHistory.cpp
>
Weird! I'll file a bug on bugzilla about that.
|
|
Assignee | |
Comment 10•19 years ago
|
||
It's probably https://bugzilla.mozilla.org/show_bug.cgi?id=303683
|
|
Assignee | |
Comment 11•19 years ago
|
||
checked on on trunk
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•19 years ago
|
Attachment #226538 -
Flags: approval1.8.1?
|
|
||
Comment 12•19 years ago
|
||
Bryner thanks for a getting a patch together for this. Does there need to be a corresponding removeObserver call or does this get cleaned up automatically at shutdown?
|
|
Assignee | |
Comment 13•19 years ago
|
||
(In reply to comment #12)
> Bryner thanks for a getting a patch together for this. Does there need to be a
> corresponding removeObserver call or does this get cleaned up automatically at
> shutdown?
>
This gets cleaned up automatically when the observer service shuts down.
|
||
Comment 14•19 years ago
|
||
Comment on attachment 226538 [details] [diff] [review]
patch (against MOZILLA_1_8_BRANCH)
a=darin on behalf of drivers
Attachment #226538 -
Flags: approval1.8.1? → approval1.8.1+
Component: History: Session → Document Navigation
QA Contact: history.session → docshell
You need to log in
before you can comment on or make changes to this bug.
Description
•