306862 - session history should flush content viewers on memory-pressure notification

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Brian Ryner (not reading)]

When the memory-pressure notification is sent through the observer service, 
session history should evict all cached content viewers to free up memory.

Comment 1

[Mike Schroepfer]

Will eval for 1.8b5 once we see the level of risk for the patch.

Comment 2

[Mike Schroepfer]

Bryner - are you working on this for b2?

Comment 3

[Asa Dotzler [:asa]]

I believe bryner is working on bug 292965 right now. When that's fixed, we
should get him to tell us more about this bug.

Comment 4

[Mike Connor [:mconnor]]

Please renominate if a patch appears for this, but the lack of visible action
makes this a non-blocker for now.

Comment 5

[Mike Schroepfer]

Bryner - will we have any chance for this in 1.8.1?

Comment 6

[Brian Ryner (not reading)]

Sure, this should be really easy

Comment 7

[Brian Ryner (not reading)]

Attachment: patch (against MOZILLA_1_8_BRANCH)

Comment 8

[Marria Nazif]

Comment on attachment 226538 [details] [diff] [review]
patch (against MOZILLA_1_8_BRANCH)

weird, when i view this attachment as diff it says the file is at mozilla/xpfe/cxpfe/components/shistory/src/nsSHistory.cpp

Comment 9

[Brian Ryner (not reading)]

(In reply to comment #8)
> (From update of attachment 226538 [details] [diff] [review] [edit])
> weird, when i view this attachment as diff it says the file is at
> mozilla/xpfe/cxpfe/components/shistory/src/nsSHistory.cpp 
> 

Weird!  I'll file a bug on bugzilla about that.

Comment 10

[Brian Ryner (not reading)]

It's probably https://bugzilla.mozilla.org/show_bug.cgi?id=303683

Comment 11

[Brian Ryner (not reading)]

checked on on trunk

Comment 12

[Mike Schroepfer]

Bryner thanks for a getting a patch together for this.  Does there need to be a corresponding removeObserver call or does this get cleaned up automatically at shutdown?

Comment 13

[Brian Ryner (not reading)]

(In reply to comment #12)
> Bryner thanks for a getting a patch together for this.  Does there need to be a
> corresponding removeObserver call or does this get cleaned up automatically at
> shutdown?
> 

This gets cleaned up automatically when the observer service shuts down.

Comment 14

[Darin Fisher]

Comment on attachment 226538 [details] [diff] [review]
patch (against MOZILLA_1_8_BRANCH)

a=darin on behalf of drivers

Comment 15

[Brian Ryner (not reading)]

fixed on branch