calendarManagerDNDObserver was in calendarManager.js, which is no longer packaged/included in Sunbird. While the views DND stuff will no longer be necessary once the new views come in, this observer should be brought back, as it handles external files being dropped on Sunbird.
Created attachment 194691 [details] [diff] [review] new dnd observer The beginning of a new dnd observer. This should bring back most of the functionality that was previously in Sunbird 0.2. I've tested the "text/x-moz-url" case fairly extensively, but the others are relying more on the old-code base than actual testing. :-/
I suggest that for 0.3a1, we just remove the drag-and-drop part. (which is actually just dropping external files on sunbird) I'm not too happy about adding even more new, untested, code.
Created attachment 194760 [details] [diff] [review] remove most dnd support This patch removes the vast majority of dnd calls/support. The ability to drag across open time in the day/week view to create a new event still remains, since this was fixed relatively recently by bug 286777. Code from the old-views was simply removed, but calendar.xul code, which can be re-used, was simply commented out.
Assignee: mostafah → jminta
Status: NEW → ASSIGNED
Attachment #194760 - Flags: first-review?(mvl)
Comment on attachment 194760 [details] [diff] [review] remove most dnd support I was only talking about calendarManagerDNDObserver, not all the other drag-and-drop. The others seem to work, no need to remove them.
Comment on attachment 194760 [details] [diff] [review] remove most dnd support I was wrong, drag-and-drop for the views doesn't work. Guess we have to live without it. But it will come back, i'm sure :)
Attachment #194760 - Flags: first-review?(mvl) → first-review+
Patch checked in. I'll file a new bug to bring some of this stuff back for 0.3a2.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Comment on attachment 194691 [details] [diff] [review] new dnd observer This bug is marked fixed, so I'm removing this review request. This patch did something different from the eventual solution of the bug (it implemented dnd-import) and we'll probably want to get that back in for 0.3a2, but the way to do that at least needs to change somewhat from this patch.
You need to log in before you can comment on or make changes to this bug.