306881 - fix canvas pattern repeat attribute

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Right now canvas patterns aren't set to repeat like the should be per the spec.
 This fixes this, and also fixes a late spec change to arc().

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: fix-canvas-pattern-repeat.patch

Comment 2

[Kamiel Martinet]

Vladimir,

Changing the arc method to reflect the changes in the spec makes it incompatible
with Safari's implementation. Drawing arcs clockwise or counterclockwise is
completely different and would result in a faulty rendered image in one or the
other.
I don't know what Hixie's reasons where for changing this but this would make it
impossible to write a cross browser script without doing some sort off browser
sniffing.
I would stick with the current solution since that doesn't break anything.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

It doesn't create an inconsistency, unless I screwed up somewhere; Safari had a
documentation error, whereas their implementation does what this does.  We
agreed with the Safari devs to just change the documentation.

Comment 4

[Kamiel Martinet]

Your absolutely right.