The default bug view has changed. See this FAQ.

fix canvas pattern repeat attribute

RESOLVED FIXED

Status

()

Core
Canvas: 2D
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: vlad, Assigned: vlad)

Tracking

({fixed1.8})

Trunk
x86
All
fixed1.8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
Right now canvas patterns aren't set to repeat like the should be per the spec.
 This fixes this, and also fixes a late spec change to arc().
(Assignee)

Comment 1

12 years ago
Created attachment 194697 [details] [diff] [review]
fix-canvas-pattern-repeat.patch
Attachment #194697 - Flags: review?(pavlov)
Attachment #194697 - Flags: approval1.8b5?

Updated

12 years ago
Attachment #194697 - Flags: review?(pavlov) → review+

Updated

12 years ago
Attachment #194697 - Flags: approval1.8b5? → approval1.8b5+
(Assignee)

Updated

12 years ago
Keywords: fixed1.8

Comment 2

12 years ago
Vladimir,

Changing the arc method to reflect the changes in the spec makes it incompatible
with Safari's implementation. Drawing arcs clockwise or counterclockwise is
completely different and would result in a faulty rendered image in one or the
other.
I don't know what Hixie's reasons where for changing this but this would make it
impossible to write a cross browser script without doing some sort off browser
sniffing.
I would stick with the current solution since that doesn't break anything.
(Assignee)

Comment 3

12 years ago
It doesn't create an inconsistency, unless I screwed up somewhere; Safari had a
documentation error, whereas their implementation does what this does.  We
agreed with the Safari devs to just change the documentation.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Comment 4

12 years ago
Your absolutely right.
You need to log in before you can comment on or make changes to this bug.