306987 - -moz-appearance: menulist-button uses css styled dropdown on top of native widget

Status: RESOLVED WORKSFORME

(Core :: Widget: Gtk, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

This bug was raised when gtk got it's own menulist.css. There we have following
definition:

.menulist-dropmarker {
  display: none;
}

That's quiet a wrong solution. Yes, it's hiding the CSS styled dropdown marker
but raises another issues:

* Running classic on systems without native theming support wouldn't show any
dropdown marker!
* We don't know the width of the system side dropdown marker. So hiding the CSS
styled one results in overlapping (see attachment 190268 [details]).

Thats why we should sync the CSS with the windows part:

.menulist-dropmarker {
  -moz-appearance: menulist-button;
  min-width: 17px;
  -moz-box-align: center;
  -moz-box-pack: center;
  border: 2px solid;
  background-color: -moz-Dialog;
  list-style-image: url("chrome://global/skin/arrow/arrow-dn.gif");
}

In that case we solve both issues described above. But another one is raised.
Even we said to use a native widget the CSS dropdown is drawed above the native
one. See e.g. the 'From:' menulist dropdown in attachment 187061 [details].

If native theming is supported and should be used by having '-moz-appearance:
menulist-button' the CSS styled dropdown shouldn't be drawn.

This bug is breaking our UI for Linux significantly. I'll add an attachment of
the current behavior on a theme with a wider native dropdown marker. Windows is
still not affected and is drawing well the dropdown marker.

Scott, could we risk to mark this as blocker for 1.5?

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Attachment: gtk style with text and dropdown overlapping

Comment 2

[Julien "_FrnchFrgg_" RIVAUD]

This bug have been resolved by recent work on native theming.