307005 - NS_ERROR_UNEXPECTED when using evalInSandbox with XPCNativeWrapper

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Aaron Boodman]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b3) Gecko/20050712 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b3) Gecko/20050712 Firefox/1.0+

If you set the __proto__ of a sandbox being used with evalInSandbox to an
XPCNativeWrapper object, it doesn't work and you only get a generic error
message. It should work the same as it does without the XPCNativeWrapper so long
as the methods being called actually exist, and it should throw a descriptive
'method not defined' error with line number if they do not.

Reproducible: Always

Steps to Reproduce:
1. Run example code.
Actual Results:  
JS console says:
Error: uncaught exception: [Exception... "Unexpected error"  nsresult:
"0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame ::
file:///C:/Documents%20and%20Settings/aa/Desktop/evalInSandbox.html ::
<TOP_LEVEL> :: line 6"  data: no]

Expected Results:  
It should show an alert box that says 'inside eval'.

If you uncomment line 5 it works correctly.

Comment 1

[Brendan Eich [:brendan]]

Calling Dr. BKap!  Calling Dr. BKap!

/be

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Aaron, is there a testcase that wants to be attached to this bug?

Comment 3

[Martijn Wargers (dead)]

Attachment: testcase

Well, just look at the url, not? 
This is the testcase from the url.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Doh, I tend not to look at the URL field :(

I'll try to see what's going on when my new debug build finishes building.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fix

So the problem here is that XPC native wrappers can have their functions called
with a |this| object that isn't a native wrapper if the native wrapper itself
is in the prototype chain. This patch makes XPCNativeWrappers deal with that
case.

Comment 6

[Brendan Eich [:brendan]]

Comment on attachment 195793 [details] [diff] [review]
Fix

Cool, glad you avoided extra null tests in the common case by testing and
throwing inside the while loop.

/be

Comment 7

[Brendan Eich [:brendan]]

We need this fixed for 1.8final/Firefox 1.5.

/be

Comment 8

[Johnny Stenback (:jst)]

Comment on attachment 195793 [details] [diff] [review]
Fix

r=jst

Comment 9

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into trunk.

Comment 10

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into MOZILLA_1_8_BRANCH.